Skip to content

Add dml hook for extensions #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gfphoenix78 merged 1 commit into from
Dec 14, 2023
Merged

Add dml hook for extensions #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/backend/commands/copyfrom.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,6 +1093,8 @@ CopyFrom(CopyFromState cstate)
appendonly_dml_init(resultRelInfo->ri_RelationDesc, CMD_INSERT);
else if (RelationIsAoCols(resultRelInfo->ri_RelationDesc))
aoco_dml_init(resultRelInfo->ri_RelationDesc, CMD_INSERT);
else if (ext_dml_init_hook)
ext_dml_init_hook(resultRelInfo->ri_RelationDesc, CMD_INSERT);

for (;;)
{
Expand Down Expand Up @@ -1533,6 +1535,8 @@ CopyFrom(CopyFromState cstate)
appendonly_dml_finish(resultRelInfo->ri_RelationDesc, CMD_INSERT);
else if (RelationIsAoCols(resultRelInfo->ri_RelationDesc))
aoco_dml_finish(resultRelInfo->ri_RelationDesc, CMD_INSERT);
else if (ext_dml_finish_hook)
ext_dml_finish_hook(resultRelInfo->ri_RelationDesc, CMD_INSERT);

MemoryContextSwitchTo(oldcontext);

Expand Down
2 changes: 2 additions & 0 deletions src/backend/commands/createas.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,8 @@ intorel_startup_dummy(DestReceiver *self, int operation, TupleDesc typeinfo)
appendonly_dml_init(((DR_intorel *)self)->rel, CMD_INSERT);
else if (RelationIsAoCols(((DR_intorel *)self)->rel))
aoco_dml_init(((DR_intorel *)self)->rel, CMD_INSERT);
else if (ext_dml_init_hook)
ext_dml_init_hook(((DR_intorel *)self)->rel, CMD_INSERT);
}

/*
Expand Down
2 changes: 2 additions & 0 deletions src/backend/commands/matview.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,6 +864,8 @@ transientrel_startup(DestReceiver *self, int operation, TupleDesc typeinfo)
appendonly_dml_init(myState->transientrel, CMD_INSERT);
else if (RelationIsAoCols(myState->transientrel))
aoco_dml_init(myState->transientrel, CMD_INSERT);
else if (ext_dml_init_hook)
ext_dml_init_hook(myState->transientrel, CMD_INSERT);

/*
* Valid smgr_targblock implies something already wrote to the relation.
Expand Down
2 changes: 2 additions & 0 deletions src/backend/commands/tablecmds.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7132,6 +7132,8 @@ ATRewriteTable(AlteredTableInfo *tab, Oid OIDNewHeap, LOCKMODE lockmode)
Assert(RelationIsAoCols(oldrel));
aoco_dml_init(newrel, CMD_INSERT);
}
else if (newrel && ext_dml_init_hook)
ext_dml_init_hook(newrel, CMD_INSERT);

/*
* Switch to per-tuple memory context and reset it for each tuple
Expand Down
6 changes: 5 additions & 1 deletion src/backend/executor/execPartition.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,6 +864,8 @@ ExecInitPartitionInfo(ModifyTableState *mtstate, EState *estate,
appendonly_dml_init(leaf_part_rri->ri_RelationDesc, mtstate->operation);
else if (RelationIsAoCols(leaf_part_rri->ri_RelationDesc))
aoco_dml_init(leaf_part_rri->ri_RelationDesc, mtstate->operation);
else if (ext_dml_init_hook)
ext_dml_init_hook(leaf_part_rri->ri_RelationDesc, mtstate->operation);

MemoryContextSwitchTo(oldcxt);

Expand Down Expand Up @@ -1178,8 +1180,10 @@ ExecCleanupTupleRouting(ModifyTableState *mtstate,
*/
if (RelationIsAoRows(resultRelInfo->ri_RelationDesc))
appendonly_dml_finish(resultRelInfo->ri_RelationDesc, mtstate->operation);
if (RelationIsAoCols(resultRelInfo->ri_RelationDesc))
else if (RelationIsAoCols(resultRelInfo->ri_RelationDesc))
aoco_dml_finish(resultRelInfo->ri_RelationDesc, mtstate->operation);
else if (ext_dml_finish_hook)
ext_dml_finish_hook(resultRelInfo->ri_RelationDesc, mtstate->operation);

ExecCloseIndices(resultRelInfo);
table_close(resultRelInfo->ri_RelationDesc, NoLock);
Expand Down
6 changes: 6 additions & 0 deletions src/backend/executor/nodeModifyTable.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@
#include "utils/lsyscache.h"
#include "utils/snapmgr.h"

ext_dml_func_hook_type ext_dml_init_hook = NULL;
ext_dml_func_hook_type ext_dml_finish_hook = NULL;

typedef struct MTTargetRelLookup
{
Expand Down Expand Up @@ -3069,6 +3071,8 @@ ExecInitModifyTable(ModifyTable *node, EState *estate, int eflags)
appendonly_dml_init(resultRelInfo->ri_RelationDesc, operation);
else if (RelationIsAoCols(resultRelInfo->ri_RelationDesc))
aoco_dml_init(resultRelInfo->ri_RelationDesc, operation);
else if (ext_dml_init_hook)
ext_dml_init_hook(resultRelInfo->ri_RelationDesc, operation);

resultRelInfo++;
i++;
Expand Down Expand Up @@ -3527,6 +3531,8 @@ ExecEndModifyTable(ModifyTableState *node)
node->operation);
else if (RelationIsAoCols(resultRelInfo->ri_RelationDesc))
aoco_dml_finish(resultRelInfo->ri_RelationDesc, node->operation);
else if (ext_dml_finish_hook)
ext_dml_finish_hook(resultRelInfo->ri_RelationDesc, node->operation);

/*
* Cleanup the initialized batch slots. This only matters for FDWs
Expand Down
9 changes: 9 additions & 0 deletions src/include/access/tableam.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2193,4 +2193,13 @@ extern const TableAmRoutine *GetHeapamTableAmRoutine(void);
extern bool check_default_table_access_method(char **newval, void **extra,
GucSource source);

/* ----------------------------------------------------------------------------
* Hook function to run init/fini for storage extensions
* ----------------------------------------------------------------------------
*/
enum CmdType;
typedef void (*ext_dml_func_hook_type) (Relation relation, enum CmdType operation);
extern PGDLLIMPORT ext_dml_func_hook_type ext_dml_init_hook;
extern PGDLLIMPORT ext_dml_func_hook_type ext_dml_finish_hook;

#endif /* TABLEAM_H */