Skip to content

[AQUMV] Avoid misbehaviors that are not supported currently. #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avamingli merged 1 commit into from
Jan 5, 2024
Merged

[AQUMV] Avoid misbehaviors that are not supported currently. #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/backend/optimizer/README.cbdb.aqumv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,11 @@ Below are not supported now:
Group By/Grouping Sets/Rollup/Cube (on mv_query)
Window Functions
CTE
Distinct
Distinct On
UNION/INTERSECT/EXCEPT
FOR UPDATE, FOR NO KEY UPDATE, FOR SHARE, FOR KEY SHARE
Scatter By
Refresh Materialized View
Create AS
Partition Tables
Expand Down
13 changes: 12 additions & 1 deletion src/backend/optimizer/plan/aqumv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,10 @@ answer_query_using_materialized_views(PlannerInfo *root,
/* Group By without agg could be possible though IMMV doesn't support it yet. */
bool can_not_use_mv = (parse->commandType != CMD_SELECT) ||
(parse->rowMarks != NIL) ||
(parse->distinctClause != NIL) ||
(parse->scatterClause != NIL) ||
(parse->cteList != NIL) ||
(parse->setOperations != NULL) ||
parse->hasWindowFuncs ||
parse->hasDistinctOn ||
parse->hasModifyingCTE ||
Expand Down Expand Up @@ -211,7 +215,14 @@ answer_query_using_materialized_views(PlannerInfo *root,
mvQuery->hasWindowFuncs ||
mvQuery->hasDistinctOn ||
mvQuery->hasModifyingCTE ||
mvQuery->hasSubLinks)
mvQuery->hasSubLinks ||
(mvQuery->groupClause != NIL) ||
/* IVM doesn't support belows now, just in case. */
(mvQuery->rowMarks != NIL) ||
(mvQuery->distinctClause != NIL) ||
(mvQuery->cteList != NIL) ||
(mvQuery->setOperations != NULL) ||
(mvQuery->scatterClause != NIL))
continue;

if (list_length(mvQuery->jointree->fromlist) != 1)
Expand Down