Skip to content

Add icw parallel test in cicd pipeline#72

Merged
my-ship-it merged 1 commit intoapache:mainfrom
sandiandian:add-icw-parallel
Jul 26, 2023
Merged

Add icw parallel test in cicd pipeline#72
my-ship-it merged 1 commit intoapache:mainfrom
sandiandian:add-icw-parallel

Conversation

@sandiandian
Copy link
Copy Markdown
Contributor

@sandiandian sandiandian commented Jul 24, 2023

Add icw-parallel-test to the cici pipeline
Not running pipline while drafting pr

closes: #ISSUE


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders before you submit the pull request:

  • Document changes
  • Communicate in the GitHub Issues or Discussions (list them if needed)
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel

@tuhaihe
Copy link
Copy Markdown
Member

tuhaihe commented Jul 24, 2023

Hi @baotingfang @my-ship-it, Please help review this PR. Thanks!

@avamingli
Copy link
Copy Markdown
Contributor

Hi, @sandiandian Shall we add GUC gp_appendonly_insert_files = 0 by the way, other prs may depend on it like #39

@my-ship-it
Copy link
Copy Markdown
Contributor

Hi @sandiandian Please update your commit message so that we know the purpose of this PR? Thx!

Copy link
Copy Markdown
Contributor Author

@sandiandian sandiandian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add icw-parallel-test to the cici pipeline
Not running pipline while drafting pr

@sandiandian sandiandian deleted the add-icw-parallel branch July 24, 2023 09:54
@sandiandian sandiandian restored the add-icw-parallel branch July 24, 2023 10:00
@sandiandian sandiandian reopened this Jul 24, 2023
avamingli
avamingli previously approved these changes Jul 25, 2023
avamingli
avamingli previously approved these changes Jul 25, 2023
Copy link
Copy Markdown
Contributor

@avamingli avamingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avamingli avamingli added the priority: High After critical issues are fixed, these should be dealt with before any further issues. label Jul 25, 2023
@wfnuser
Copy link
Copy Markdown
Contributor

wfnuser commented Jul 25, 2023

The commit messages seem like a combination of several squashed commit header. I suggest rewrite it. @sandiandian

my-ship-it
my-ship-it previously approved these changes Jul 25, 2023
@avamingli
Copy link
Copy Markdown
Contributor

avamingli commented Jul 25, 2023

Many prs are waiting for this, seems it's queued in CI test, is there any way to prioritize this pr? @my-ship-it @sandiandian

@sandiandian
Copy link
Copy Markdown
Contributor Author

I can add the ci runner @avamingli

@sandiandian sandiandian dismissed stale reviews from my-ship-it and avamingli via d57afc9 July 25, 2023 11:11
Copy link
Copy Markdown
Contributor

@baotingfang baotingfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

add icw-parallel-test to the cici pipeline
not running pipline while drafting pr
add gp_appendonly_insert_files=0 parameter for cbdb tests#39
@my-ship-it my-ship-it merged commit 970fda7 into apache:main Jul 26, 2023
lss602726449 pushed a commit to lss602726449/cloudberrydb that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: High After critical issues are fixed, these should be dealt with before any further issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants