Skip to content

Add Parallel Bitmap Heap Scan case#85

Merged
my-ship-it merged 1 commit intoapache:mainfrom
avamingli:p_bitmap_heap_scan
Aug 7, 2023
Merged

Add Parallel Bitmap Heap Scan case#85
my-ship-it merged 1 commit intoapache:mainfrom
avamingli:p_bitmap_heap_scan

Conversation

@avamingli
Copy link
Copy Markdown
Contributor

@avamingli avamingli commented Jul 24, 2023

Issue #65 says we need to support Parallel Bitmap Heap Scan.
I don't have the impression that we disable it at some time.
Have a check and yeah, we have it, but lack of a case.
Add a case to show that.

explain(costs off) select c2 from t1;
                 QUERY PLAN
--------------------------------------------
 Gather Motion 6:1  (slice1; segments: 6)
   ->  Parallel Bitmap Heap Scan on t1
         ->  Bitmap Index Scan on t1_c2_idx

By adding the cases, found that the underling Bitmap Index Scan Locus is NULL.
It's not so right and may cause confusion even it doesn't have an impact on Plan Execution.

explain(locus, costs off) select c2 from t1;
                 QUERY PLAN                 
--------------------------------------------
 Gather Motion 6:1  (slice1; segments: 6)
   Locus: Entry
   ->  Parallel Bitmap Heap Scan on t1
         Locus: HashedWorkers
         Parallel Workers: 2
         ->  Bitmap Index Scan on t1_c2_idx
               Locus: NULL.    <-------------------
 Optimizer: Postgres query optimizer
(8 rows)

I have new an issue #86 to track that.

Authored-by: Zhang Mingli avamingli@gmail.com

closes: #65


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders before you submit the pull request:

  • Document changes
  • Communicate in the GitHub Issues or Discussions (list them if needed)
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel

Copy link
Copy Markdown
Contributor

@wfnuser wfnuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@avamingli avamingli force-pushed the p_bitmap_heap_scan branch from bd79297 to d41b27c Compare July 27, 2023 03:25
@sandiandian
Copy link
Copy Markdown
Contributor

There are times when test may fail due to instability and you can click retry without having to re-trigger the whole ci.

@avamingli avamingli force-pushed the p_bitmap_heap_scan branch 2 times, most recently from 0691a9b to ec70db3 Compare July 28, 2023 09:16
@avamingli avamingli requested review from my-ship-it and yjhjstz July 31, 2023 08:38
@avamingli avamingli force-pushed the p_bitmap_heap_scan branch from ec70db3 to f99de12 Compare July 31, 2023 10:10
@avamingli avamingli self-assigned this Aug 1, 2023
We have enabled Parallel Bitmap Heap Scan like:
explain(costs off) select c2 from t1;
                 QUERY PLAN
--------------------------------------------
 Gather Motion 6:1  (slice1; segments: 6)
   ->  Parallel Bitmap Heap Scan on t1
         ->  Bitmap Index Scan on t1_c2_idx

Add an case to show that.

Authored-by: Zhang Mingli avamingli@gmail.com
@avamingli avamingli force-pushed the p_bitmap_heap_scan branch from f99de12 to 216215c Compare August 2, 2023 04:23
@my-ship-it my-ship-it merged commit 1d223c9 into apache:main Aug 7, 2023
@avamingli avamingli deleted the p_bitmap_heap_scan branch August 7, 2023 10:55
tuhaihe pushed a commit that referenced this pull request Feb 27, 2026
Currently, tests for appendonly relations is missing. This patch adds
one test for that.

Co-Authored-by: Xuebin Su <sxuebin@vmware.com>
Co-Authored-by: Hao Zhang <hzhang2@vmware.com>
reshke pushed a commit that referenced this pull request Mar 11, 2026
Currently, tests for appendonly relations is missing. This patch adds
one test for that.

Co-Authored-by: Xuebin Su <sxuebin@vmware.com>
Co-Authored-by: Hao Zhang <hzhang2@vmware.com>
reshke pushed a commit to reshke/cloudberrydb that referenced this pull request Mar 11, 2026
Currently, tests for appendonly relations is missing. This patch adds
one test for that.

Co-Authored-by: Xuebin Su <sxuebin@vmware.com>
Co-Authored-by: Hao Zhang <hzhang2@vmware.com>
reshke pushed a commit to reshke/cloudberrydb that referenced this pull request Mar 12, 2026
Currently, tests for appendonly relations is missing. This patch adds
one test for that.

Co-Authored-by: Xuebin Su <sxuebin@vmware.com>
Co-Authored-by: Hao Zhang <hzhang2@vmware.com>
reshke pushed a commit to reshke/cloudberrydb that referenced this pull request Mar 12, 2026
Currently, tests for appendonly relations is missing. This patch adds
one test for that.

Co-Authored-by: Xuebin Su <sxuebin@vmware.com>
Co-Authored-by: Hao Zhang <hzhang2@vmware.com>
oppenheimer01 pushed a commit to oppenheimer01/cloudberrydb that referenced this pull request Apr 12, 2026
Currently, tests for appendonly relations is missing. This patch adds
one test for that.

Co-Authored-by: Xuebin Su <sxuebin@vmware.com>
Co-Authored-by: Hao Zhang <hzhang2@vmware.com>
oppenheimer01 pushed a commit to oppenheimer01/cloudberrydb that referenced this pull request Apr 21, 2026
Currently, tests for appendonly relations is missing. This patch adds
one test for that.

Co-Authored-by: Xuebin Su <sxuebin@vmware.com>
Co-Authored-by: Hao Zhang <hzhang2@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support parallel bitmap heap scan

5 participants