Skip to content

Doc: update Pull_Request template for contributor#91

Merged
tuhaihe merged 1 commit intoapache:mainfrom
tuhaihe:update_pr_template
Jul 26, 2023
Merged

Doc: update Pull_Request template for contributor#91
tuhaihe merged 1 commit intoapache:mainfrom
tuhaihe:update_pr_template

Conversation

@tuhaihe
Copy link
Copy Markdown
Member

@tuhaihe tuhaihe commented Jul 25, 2023

See: Discussion#20 http://github.com/orgs/cloudberrydb/discussions/20


Change logs

Update the contributor's checklist type from a bulleted list to a task list, so that contributors can check them before/when they submit PRs.

Why are the changes needed?

For a better check to contributors.

Does this PR introduce any user-facing change?

No, no changes to the core code.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders before you submit the pull request:

  • Document changes
  • Communicate in the GitHub Issues or Discussions (list them if needed)
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel

@tuhaihe tuhaihe requested review from avamingli and yjhjstz July 25, 2023 02:31
@tuhaihe tuhaihe added type: Documentation Improvements or additions to documentation priority: Medium This issue may be useful, and needs some attention. labels Jul 25, 2023
@tuhaihe tuhaihe self-assigned this Jul 25, 2023
@tuhaihe tuhaihe requested a review from wfnuser July 25, 2023 06:32
@my-ship-it
Copy link
Copy Markdown
Contributor

Hi @tuhaihe Please don't use merge for first commit in your pull request. We need to keep git history linear.

@avamingli
Copy link
Copy Markdown
Contributor

Hi @tuhaihe Please don't use merge for first commit in your pull request. We need to keep git history linear.

Use rebase instead.

@tuhaihe
Copy link
Copy Markdown
Member Author

tuhaihe commented Jul 26, 2023

Got it, thanks! @my-ship-it @avamingli

Update the contributor's checklist type from a bulleted list to a task
list, so that contributors can check them before/when they submit PRs.

See: Discussion#20 <http://github.com/orgs/cloudberrydb/discussions/20>
@tuhaihe tuhaihe force-pushed the update_pr_template branch from b41777b to 424c29a Compare July 26, 2023 06:59
@tuhaihe
Copy link
Copy Markdown
Member Author

tuhaihe commented Jul 26, 2023

I dropped the merge history and rebased my commit, PTAL again! @avamingli

@tuhaihe tuhaihe merged commit c9dbca2 into apache:main Jul 26, 2023
@tuhaihe tuhaihe deleted the update_pr_template branch September 26, 2023 02:41
tuhaihe pushed a commit that referenced this pull request Feb 27, 2026
1. add relation_cache_lock
2. add relation_cache and relid_cache in SHM
3. add relation_cache test case

Co-authored-by: hzhang2 <hzhang2@vmware.com>
Co-authored-by: Xuebin Su (苏学斌) <sxuebin@vmware.com>
Co-authored-by: Xing Guo <higuoxing+github@gmail.com>
reshke pushed a commit that referenced this pull request Mar 11, 2026
1. add relation_cache_lock
2. add relation_cache and relid_cache in SHM
3. add relation_cache test case

Co-authored-by: hzhang2 <hzhang2@vmware.com>
Co-authored-by: Xuebin Su (苏学斌) <sxuebin@vmware.com>
Co-authored-by: Xing Guo <higuoxing+github@gmail.com>
reshke pushed a commit to reshke/cloudberrydb that referenced this pull request Mar 11, 2026
1. add relation_cache_lock
2. add relation_cache and relid_cache in SHM
3. add relation_cache test case

Co-authored-by: hzhang2 <hzhang2@vmware.com>
Co-authored-by: Xuebin Su (苏学斌) <sxuebin@vmware.com>
Co-authored-by: Xing Guo <higuoxing+github@gmail.com>
reshke pushed a commit to reshke/cloudberrydb that referenced this pull request Mar 12, 2026
1. add relation_cache_lock
2. add relation_cache and relid_cache in SHM
3. add relation_cache test case

Co-authored-by: hzhang2 <hzhang2@vmware.com>
Co-authored-by: Xuebin Su (苏学斌) <sxuebin@vmware.com>
Co-authored-by: Xing Guo <higuoxing+github@gmail.com>
reshke pushed a commit to reshke/cloudberrydb that referenced this pull request Mar 12, 2026
1. add relation_cache_lock
2. add relation_cache and relid_cache in SHM
3. add relation_cache test case

Co-authored-by: hzhang2 <hzhang2@vmware.com>
Co-authored-by: Xuebin Su (苏学斌) <sxuebin@vmware.com>
Co-authored-by: Xing Guo <higuoxing+github@gmail.com>
oppenheimer01 pushed a commit to oppenheimer01/cloudberrydb that referenced this pull request Apr 12, 2026
1. add relation_cache_lock
2. add relation_cache and relid_cache in SHM
3. add relation_cache test case

Co-authored-by: hzhang2 <hzhang2@vmware.com>
Co-authored-by: Xuebin Su (苏学斌) <sxuebin@vmware.com>
Co-authored-by: Xing Guo <higuoxing+github@gmail.com>
oppenheimer01 pushed a commit to oppenheimer01/cloudberrydb that referenced this pull request Apr 21, 2026
1. add relation_cache_lock
2. add relation_cache and relid_cache in SHM
3. add relation_cache test case

Co-authored-by: hzhang2 <hzhang2@vmware.com>
Co-authored-by: Xuebin Su (苏学斌) <sxuebin@vmware.com>
Co-authored-by: Xing Guo <higuoxing+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: Medium This issue may be useful, and needs some attention. type: Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants