Support 4.x compatibility #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yadvr
approved these changes
Nov 29, 2021
Member
|
@davidjumani how have we tested this? (apart from the unit test) |
Contributor
Author
|
@rhtyd Yes, ran a couple of tests targetting the ManagementServerId with both int and string data types in the response JSON |
davidjumani
force-pushed
the
support-4.x
branch
from
f6ca004 to
e3a75a3
Compare
davidjumani
force-pushed
the
support-4.x
branch
from
e3a75a3 to
9e40b89
Compare
Member
|
Alright @psycofdj @davidjumani thanks for coming to some solution that satisfies both your requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modded version of #21
Allows backward compatibility of Managementserverid of both int64 and string data types