-
Notifications
You must be signed in to change notification settings - Fork 36
Feature/vm wizard #146
Feature/vm wizard #146
Conversation
compute: work-in-progress VM deployment wizard (#7)
merge from "master" into "feature/vm-wizard"
|
Thanks for submitting @utchoang @svenvogel @PaulAngus @borisstoyanov @andrijapanicsb @DaanHoogland - from internal discussions one feedback I (got from Alex) is that the VM deployment wizard should not allow creation of new networks which may be confusing for users (multiple ways to do the same thing), instead we can add a help button or text that allows users to go to the network page and create the network they want themselves. This would however remove the previous UX that allowed users to add network while they deploy a VM. Thoughts? |
|
+1 @rhtyd for network stuff during vm deployment wizard, but as suggested, please add some button so that user can still create a network. |
vpc: consolidated tabs for configuration and management (apache#143)
|
@rhtyd I think I will add a Help button for creating new network while avoiding content switch |
|
@rhtyd i my experience most of my infra user find a way for creating a network in the wizard in the process of creating a virtual machine a good way. do complete creation in one step. my most users here was confused in the old UI because they dont know "whats that for network type and where is it connected"... if this is better in new UI i think it will not confuse. i see 2 ways.
@rhtyd what do you think? |
Merge branch master into utchoang:feature/vm-wizard
|
@svenvogel I don't like the collapse mode, I would prefer all sections are visible. I'm okay either way to provide an option for users to create network. Maybe the network list/table can also say things like the type of the network, cidr etc. Help button is also fine. We may even reuse the create network component here to allow users to create a network, if they don't want to use an existing one. There are some organisations that prefer network to be created, others don't. In most cases, say when deploying a VM (whether on cloud, or on desktop/server like VirtualBox or virt-manager) users usually are not allowed to create a network. For many providers the existing list of networks is like a network offering available to VMs, and users are generally only allowed to pick one of the existing ones (than create a new one). We can use router-link to allow users create networks for example? |
Merge branch master into utchoang:feature/vm-wizard
|
@rhtyd cc @svenvogel There is error 503 found in http://acs.shapeblue.com:8080/client/. Please check |
Merge branch master into feature/vm-wizard
|
@rhtyd cc @svenvogel |
|
@rhtyd cc @svenvogel |
|
@utchoang that's fine for the first iteration, I think as we had initially discussed I would rather prefer that all the views/sections are visible by default instead of steps/pages like the old UI's wizard. Perhaps once a user inputs say all the params of one step, the subsequent step may automatically show up? In summary, let's just see if we can finish the first iteration and then seek feedback/reviews. |
|
@utchoang i agree with @rhtyd ... please combine the nice 1..2..3 blue step line but WITH one pager (scrollable in each section) ... "no next button". it is easier for user to change. maybe we had an misunderstood. additional |
|
@rhtyd cc @svenvogel I have changed the following. Please let me know your comments. |
Merge branch master into utchoang:feature/vm-wizard
|
@rhtyd Yes, I did merge the last master |
|
Great @utchoang, I'll start review/testing. |
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
|
@rhtyd CC @utchoang should we add groups, keyboard layout and userdata? |
|
@utchoang please pull --rebase your branch as I've made some changes and merged origin/master on it. As Sven describes, the following can be added:
Rest is largely done, but I'm still reviewing/testing it. |
|
@utchoang is this ready for review/testing now? |
|
@rhtyd I completed fixes. Please review again |
Merge branch master into utchoang:feature/vm-wizard
Merge branch master into utchoang:feature/vm-wizard
Merge branch master into utchoang:feature/vm-wizard
|
@utchoang we don't have the functionality to add a new network on the fly like in old UI?
Deployment works with minimal changes to variables. Will try more variations and will try to provide some fixes tomorrow. cc @rhtyd |
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> (cherry picked from commit 061ca11) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
|
There are still some issue but largely the feature works for some combination, I'll merge and hopefully the bugs can be fixed over time cc @shwstppr @utchoang @vladimirpetrov |
|
Added bug #254 |
A mostly functional vm deployment wizard. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>











Uh oh!
There was an error while loading. Please reload this page.