Skip to content
This repository was archived by the owner on Jan 20, 2021. It is now read-only.

Conversation

@utchoang
Copy link

@utchoang utchoang commented Feb 5, 2020

  • Add selection for disk offering
  • Format Info card for vm config summary
  • Add iso selection
  • Add tags to the templates (featured, public, etc.)
  • Sort templates/isos
  • Pin featured templates/isos at the top of each list
  • Add search filter input for isos/templates
  • Handle form change on switching from template to iso (and vice versa)
  • Add translations for all input placeholders
  • Implement submit method
  • Add affinity group selection
  • Add network configuration (ip, mac) to network list params
  • Add ssh key pairs selection
  • Handle Navigation (e.g. reset the form on navigating away)
  • Add filter possibility to selections (compute offering, disk offering, network offering, ...)
  • Change layout from collapse to steps
  • Add pod, cluster and host in step Basic Setup

Hoang Nguyen added 4 commits January 31, 2020 16:19
@yadvr
Copy link
Member

yadvr commented Feb 5, 2020

Thanks for submitting @utchoang

@svenvogel @PaulAngus @borisstoyanov @andrijapanicsb @DaanHoogland - from internal discussions one feedback I (got from Alex) is that the VM deployment wizard should not allow creation of new networks which may be confusing for users (multiple ways to do the same thing), instead we can add a help button or text that allows users to go to the network page and create the network they want themselves. This would however remove the previous UX that allowed users to add network while they deploy a VM. Thoughts?

@andrijapanicsb
Copy link
Contributor

+1 @rhtyd for network stuff during vm deployment wizard, but as suggested, please add some button so that user can still create a network.

vpc: consolidated tabs for configuration and management (apache#143)
@utchoang
Copy link
Author

utchoang commented Feb 6, 2020

@rhtyd I think I will add a Help button for creating new network while avoiding content switch

@svenvogel
Copy link

@rhtyd i my experience most of my infra user find a way for creating a network in the wizard in the process of creating a virtual machine a good way. do complete creation in one step. my most users here was confused in the old UI because they dont know "whats that for network type and where is it connected"... if this is better in new UI i think it will not confuse.

i see 2 ways.

  1. like @utchoang suggest i would use a help button if we dont want creation of network or "we have an ugly content switch". this means we avoid switch the site to another and back. this is from design perpective and usability not nice for handling. at the moment we have a speedy nice one pager vm wizard. each content switch will destroy it. help button like create network there... but not switch them...

  2. for me +1 for the possibility to create directly the network because we use collapse mode. users they dont want it will not use it and if you plan network before you will go directly to network tab.

@rhtyd what do you think?

Merge branch master into utchoang:feature/vm-wizard
@yadvr
Copy link
Member

yadvr commented Feb 8, 2020

@svenvogel I don't like the collapse mode, I would prefer all sections are visible. I'm okay either way to provide an option for users to create network. Maybe the network list/table can also say things like the type of the network, cidr etc. Help button is also fine. We may even reuse the create network component here to allow users to create a network, if they don't want to use an existing one.

There are some organisations that prefer network to be created, others don't. In most cases, say when deploying a VM (whether on cloud, or on desktop/server like VirtualBox or virt-manager) users usually are not allowed to create a network. For many providers the existing list of networks is like a network offering available to VMs, and users are generally only allowed to pick one of the existing ones (than create a new one). We can use router-link to allow users create networks for example?

Merge branch master into utchoang:feature/vm-wizard
@utchoang
Copy link
Author

@rhtyd cc @svenvogel There is error 503 found in http://acs.shapeblue.com:8080/client/. Please check

@utchoang
Copy link
Author

@rhtyd cc @svenvogel
This is my new design of the layout collapse mode to steps mode. Please review and let me know your comments.
2020-02-11_10-25-28
2020-02-11_10-27-50
2020-02-11_10-28-38

@utchoang
Copy link
Author

utchoang commented Feb 11, 2020

@rhtyd cc @svenvogel
Add pod, cluster and host
2020-02-11_16-48-25

@yadvr
Copy link
Member

yadvr commented Feb 11, 2020

@utchoang that's fine for the first iteration, I think as we had initially discussed I would rather prefer that all the views/sections are visible by default instead of steps/pages like the old UI's wizard. Perhaps once a user inputs say all the params of one step, the subsequent step may automatically show up?

In summary, let's just see if we can finish the first iteration and then seek feedback/reviews.

@svenvogel
Copy link

svenvogel commented Feb 11, 2020

@utchoang i agree with @rhtyd ... please combine the nice 1..2..3 blue step line but WITH one pager (scrollable in each section) ... "no next button". it is easier for user to change. maybe we had an misunderstood.

additional
i mean the next is okay... but it would be cool to switch per click to each section not with an preview or next button. i dont know what possible because this style with number and hook will be always with acknowledge button. it would be cool to have the 1..2..3... style but all on one page. maybe we get the hook button if we select the "required" settings e.g. VM Name, ...

@utchoang
Copy link
Author

utchoang commented Feb 12, 2020

@rhtyd cc @svenvogel I have changed the following. Please let me know your comments.

  1. Default:
    1

  2. Select zone:
    2
    3
    4

@utchoang
Copy link
Author

@rhtyd Yes, I did merge the last master

@yadvr
Copy link
Member

yadvr commented Feb 17, 2020

Great @utchoang, I'll start review/testing.

@yadvr yadvr removed the complex label Feb 17, 2020
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@svenvogel
Copy link

@rhtyd CC @utchoang should we add groups, keyboard layout and userdata?

image

@yadvr
Copy link
Member

yadvr commented Feb 17, 2020

@utchoang please pull --rebase your branch as I've made some changes and merged origin/master on it. As Sven describes, the following can be added:

  • Support to specify keyboard
  • Support to supply userdata (this would be sent as base64 encoded string as part of the api request)
  • The add to instance group (existing groups may be listed using the listInstanceGroups API)
  • Add pagination support for templates/isos (actually all possible views)
  • For templates/iso show another filter criteria (filter/show by featured/community/shared etc.) - this is not clear how to show - may be skipped if you don't understand it.

Rest is largely done, but I'm still reviewing/testing it.

@yadvr
Copy link
Member

yadvr commented Feb 18, 2020

@utchoang is this ready for review/testing now?

@utchoang
Copy link
Author

@rhtyd I completed fixes. Please review again

utchoang and others added 6 commits February 19, 2020 10:09
1. Add pagination support for templates/isos
2. Add filter templates/isos by tags
Merge branch master into utchoang:feature/vm-wizard
Merge branch master into utchoang:feature/vm-wizard
Merge branch master into utchoang:feature/vm-wizard
@yadvr yadvr added this to the 0.5.0-technical-preview milestone Mar 25, 2020
@shwstppr
Copy link
Contributor

shwstppr commented Mar 25, 2020

@utchoang we don't have the functionality to add a new network on the fly like in old UI?
Screenshot from 2020-03-25 18-25-18

Screenshot from 2020-03-25 18-17-10
And can we make changes to pre-select(first entry from the list) things like zone, compute offering, etc.

Deployment works with minimal changes to variables. Will try more variations and will try to provide some fixes tomorrow. cc @rhtyd

shwstppr and others added 2 commits March 26, 2020 01:50
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
(cherry picked from commit 061ca11)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr changed the title [WIP] Feature/vm wizard Feature/vm wizard Mar 25, 2020
yadvr added 3 commits March 26, 2020 02:17
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr
Copy link
Member

yadvr commented Mar 25, 2020

There are still some issue but largely the feature works for some combination, I'll merge and hopefully the bugs can be fixed over time cc @shwstppr @utchoang @vladimirpetrov

@yadvr yadvr merged commit 86845be into apache:master Mar 25, 2020
@yadvr
Copy link
Member

yadvr commented Mar 25, 2020

Added bug #254

@utchoang utchoang deleted the feature/vm-wizard branch April 23, 2020 01:50
weizhouapache pushed a commit that referenced this pull request Jan 19, 2021
A mostly functional vm deployment wizard.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants