Add bypassvlanoverlapcheck parameter when create private gateway #431
Conversation
src/config/section/network.js
Outdated
| listView: true, | ||
| args: ['physicalnetworkid', 'vlan', 'ipaddress', 'gateway', 'netmask', 'sourcenatsupported', 'aclid'], | ||
| // TODO : Add version check | ||
| args: ['physicalnetworkid', 'vlan', 'bypassvlanoverlapcheck', 'ipaddress', 'gateway', 'netmask', 'sourcenatsupported', 'aclid'], |
There was a problem hiding this comment.
@davidjumani no need, instead use the syntax to return args from a method (see example where args can be a () => { return ...). Basically you can use the example I showed you yesterday to check if param is available in the API to include in the args keys or no (i.e. check API discovery api.params if it exists, if yes return otherwise don't).
src/views/network/VpcTab.vue
Outdated
| ></a-input> | ||
| </a-form-item> | ||
| // TODO : Add version check | ||
| <a-form-item :label="$t('label.bypassvlanoverlapcheck')"> |
There was a problem hiding this comment.
Add check to see if API param is available, @davidjumani see e606fe9
davidjumani
force-pushed
the
vpc-vlan-bypass
branch
from
c3aece6 to
3ec5da1
Compare
davidjumani
force-pushed
the
vpc-vlan-bypass
branch
from
3ec5da1 to
9283035
Compare
|
@blueorangutan package |
|
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
|
@rhtyd Good to go! Also fixed missing vpcid when trying to create a private gateway |
3 participants
Fixes #403