CKS Data ISO registration fails but ISO is registered

[yadvr]

problem

CKS data iso registration failure doesn't automatically cleanup registered ISO.

versions

ACS 4.20.1

The steps to reproduce the bug

I tried to register a CKS data iso in an env with two zones (one fully functional, and one dummy created but with no secondary storage & disabled). It failed with an error that no image storage found, but then the ISO got registerd in the zone that was fully functional & enabled with no CKS data iso entry.

Workaround - had to remove the ISO manually. After deleting the dummy zone, re-registerd and it worked.

What to do about it?

No response

[weizhouapache]

when add a Kubenetes Version (aka register CKS ISO), we can choose the zone

[yadvr]

Can the back end handle failures so either not create isos before form validation? Or cleanup on failure?

[DaanHoogland]

@rohityadavcloud , when choosing “all zones” for an upload/registering this is a valid failure, isn't it?

It seems to me an error should be thrown. When choosing a specific zone which has storage it should not fail. Do you have the error message and command/API to share?

[Damans227]

I dug into this issue. The ISO gets created here via registerKubernetesVersionIso() → templateService.registerIso() (line 218) before the image store check happens downstream, so it's orphaned on failure. Adding upfront validation to fail fast before creating the ISO makes sense imo.