Skip to content

Don't specify ipv6 ranges for shared network #10746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weizhouapache merged 3 commits into from
Apr 24, 2025
Merged

Don't specify ipv6 ranges for shared network #10746

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f52277
assume SLAAC takes care
DaanHoogland Apr 17, 2025
054487e
log info
DaanHoogland Apr 18, 2025
db06bb7
Update server/src/main/java/com/cloud/network/NetworkServiceImpl.java
weizhouapache Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/src/main/java/com/cloud/network/NetworkServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1644,8 +1644,8 @@
if (ipv4 && Objects.isNull(startIP)) {
throw new CloudRuntimeException("IPv4 address range needs to be provided");
}
if (ipv6 && Objects.isNull(startIPv6)) {
throw new CloudRuntimeException("IPv6 address range needs to be provided");
if (ipv6) {
s_logger.info(String.format("ip range for network '%s' is specified as %s - %s", name, startIPv6, endIPv6));

Check warning on line 1648 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L1648 

Added line #L1648 was not covered by tests
}
}
Pair<Integer, Integer> interfaceMTUs = validateMtuConfig(publicMtu, privateMtu, zone.getId());
Expand Down
Loading