Skip to content

ui: do not filter edge zones while registering directdownload iso#10865

Merged
weizhouapache merged 1 commit intoapache:4.20from
shapeblue:fix-iso-edge-dd-register
Sep 3, 2025
Merged

ui: do not filter edge zones while registering directdownload iso#10865
weizhouapache merged 1 commit intoapache:4.20from
shapeblue:fix-iso-edge-dd-register

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented May 14, 2025

Description

Fixes #10766

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
ui: donot filter edge zones while registering directdownload iso
45209dc 
Fixes apache#10766

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr changed the title ui: donot filter edge zones while registering directdownload iso ui: do not filter edge zones while registering directdownload iso May 14, 2025
@shwstppr
Copy link
Contributor Author

shwstppr commented May 14, 2025

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented May 14, 2025

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented May 14, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10865 (QA-JID-622)

@codecov
Copy link

codecov bot commented May 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.36%. Comparing base (7e2aa0e) to head (45209dc).
⚠️ Report is 179 commits behind head on 4.20.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #10865      +/-   ##
============================================
+ Coverage     16.13%   18.36%   +2.23%     
- Complexity    13217    16632    +3415     
============================================
  Files          5651     5940     +289     
  Lines        496748   585518   +88770     
  Branches      60184    84935   +24751     
============================================
+ Hits          80137   107523   +27386     
- Misses       407688   466349   +58661     
- Partials       8923    11646    +2723
Flag Coverage Δ
uitests 3.63% <ø> (-0.38%) ⬇️
unittests 19.35% <ø> (+2.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

weizhouapache
weizhouapache reviewed May 19, 2025
View reviewed changes
@sureshanaparti sureshanaparti added this to the 4.20.2 milestone Jun 5, 2025
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jul 7, 2025

@kiranchavala can you have a look?

@kiranchavala
Copy link
Member

kiranchavala commented Aug 5, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Aug 5, 2025

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Aug 5, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14548

kiranchavala
kiranchavala approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Edgezone is listed for iso registration

Screenshot 2025-08-05 at 2 05 35 PM

@shwstppr shwstppr marked this pull request as ready for review August 5, 2025 10:54
@shwstppr shwstppr closed this Aug 5, 2025
@shwstppr shwstppr reopened this Aug 5, 2025
@weizhouapache weizhouapache changed the base branch from main to 4.20 September 3, 2025 09:45
@weizhouapache
Copy link
Member

weizhouapache commented Sep 3, 2025

lgtm

image

@weizhouapache weizhouapache merged commit f24b175 into apache:4.20 Sep 3, 2025
45 of 48 checks passed
@weizhouapache weizhouapache mentioned this pull request Sep 3, 2025
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 15, 2025
@shwstppr @dhslove
ui: donot filter edge zones while registering directdownload iso (apa…
8b47074 
…che#10865)

Fixes apache#10766

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weizhouapache weizhouapache weizhouapache left review comments

@kiranchavala kiranchavala kiranchavala approved these changes

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

UI: Unable to select edge zone during iso registration

6 participants

@shwstppr @blueorangutan @DaanHoogland @kiranchavala @weizhouapache @sureshanaparti