Skip to content

CLOUDSTACK-9245 - Cannot delete non-attached ACL that contains items #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asfgit merged 4 commits into from
Jan 26, 2016
Merged

CLOUDSTACK-9245 - Cannot delete non-attached ACL that contains items #1358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b106db
CLOUDSTACK-9245 - Formatting NetworkACLManagerImpl class
wilderrodrigues Jan 21, 2016
84e89a5
CLOUDSTACK-9245 - Formatting VpcManagerImpl class
wilderrodrigues Jan 21, 2016
1571e01
CLOUDSTACK-9245 - Formatting NetworkACLServiceImpl class
wilderrodrigues Jan 21, 2016
3ec37a0
CLOUDSTACK-9245 - Deletes ACL items when destroying the VPC or deleti…
wilderrodrigues Jan 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions api/src/com/cloud/network/vpc/NetworkACLService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,8 @@ public interface NetworkACLService {
Pair<List<? extends NetworkACLItem>, Integer> listNetworkACLItems(ListNetworkACLsCmd cmd);

/**
* Revoked ACL Item with specified Id
* Revoke ACL Item with specified Id
* @param ruleId
* @param apply
* @return
*/
boolean revokeNetworkACLItem(long ruleId);
Expand All @@ -121,7 +120,7 @@ public interface NetworkACLService {
* @throws ResourceUnavailableException
*/
NetworkACLItem updateNetworkACLItem(Long id, String protocol, List<String> sourceCidrList, NetworkACLItem.TrafficType trafficType, String action, Integer number,
Integer sourcePortStart, Integer sourcePortEnd, Integer icmpCode, Integer icmpType, String newUUID, Boolean forDisplay) throws ResourceUnavailableException;
Integer sourcePortStart, Integer sourcePortEnd, Integer icmpCode, Integer icmpType, String newUUID, Boolean forDisplay) throws ResourceUnavailableException;

/**
* Associates ACL with specified Network
Expand Down
Loading