CLOUDSTACK-9283: add pid to java arguments in cloudstack-usage.service #1409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
proof that this works in centos 7.2 running cloudstack 4.7.1: in /var/log/cloudstack/usage/usage.log: |
| export UCP=`ls /usr/share/cloudstack-usage/cloud-usage-*.jar /usr/share/cloudstack-usage/lib/*.jar | tr "\\n" ":"`; \ | ||
| export CLASSPATH="$UCP:/etc/cloudstack/usage:/usr/share/java/mysql-connector-java.jar"; \ | ||
| ${JAVA_HOME}/bin/java -Xms${JAVA_HEAP_INITIAL} -Xmx${JAVA_HEAP_MAX} -cp "$CLASSPATH" $JAVA_CLASS' | ||
| ${JAVA_HOME}/bin/java -Dpid=${JAVA_PID} -Xms${JAVA_HEAP_INITIAL} -Xmx${JAVA_HEAP_MAX} -cp "$CLASSPATH" $JAVA_CLASS' |
Member
There was a problem hiding this comment.
LGTM (did not test by creating packages and installing it though)
Contributor
|
FYI, this fix also worked for me, Cloudstack 4.8 on Centos7 |
Contributor
|
LGTM |
Contributor
|
Two people have confirmed this is working and we also have two LGTM. Is this one ready to merge. I don't think running CI is going to add much value beyond the manual checks people have already done. Do you guys agree? |
Member
|
@swill agree |
Contributor
|
Tested this in a 4.8 lab. I agree that there is little point in running CI against this, as it's a config change. LGTM. |
asfgit
pushed a commit
that referenced
this pull request
Apr 28, 2016
CLOUDSTACK-9283: add pid to java arguments in cloudstack-usage.servicecloudstack-usage fails to start throwing Integer exception during PID retrieval, and the service keeps restarting after 10s (as defined in the systemd service definition). Adding the pid to the java arguments in the systemd service definition makes it stop looping in centos7 * pr/1409: CLOUDSTACK-9283: add pid to java arguments in systemd/cloudstack-usage.service Signed-off-by: Will Stevens <williamstevens@gmail.com>
nathanejohnson
added a commit
to myENA/cloudstack
that referenced
this pull request
Nov 8, 2016
apache#1409 Addresses index out of range exceptions
nathanejohnson
added a commit
to myENA/cloudstack
that referenced
this pull request
Nov 8, 2016
apache#1409 add pid to java arguments in cloudstack-usage.service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloudstack-usage fails to start throwing Integer exception during PID retrieval, and the service keeps restarting after 10s (as defined in the systemd service definition).
Adding the pid to the java arguments in the systemd service definition makes it stop looping in centos7