CLOUDSTACK-9681: Make the migration of volume to go through allocator…

[anshul1886]

… so that appropraite checks are made

Also, make detached disk to go through findStoragePoolsForMigration API from UI

[koushik-das]

@anshul1886 Please resolve the conflicts. Code changes LGTM

[anshul1886]

Failures seems to be transitional in nature.

[nitin-maharana]

@anshul-gangwar : There are some tests failing from PrimaryDataStoreDaoImplTest due to extra null value, I guess. Once you fix that, we can review it. Thanks.

[anshul1886]

@koushik-das @nitin-maharana PR #1994 has the tests which is kind of forcing the SQL statements to be used in implementation. So I am thinking of way how to go about it.

[anshul1886]

Failures reported are due to network related issues which are unrelated to this PR.

[cloudmonger]

ACS CI BVT Run

Sumarry:
Build Number 1008
Hypervisor xenserver
NetworkType Advanced
Passed=107
Failed=6
Skipped=12

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0

Failed tests:

• test_deploy_vm_iso.py

• test_deploy_vm_from_iso Failing since 65 runs

• test_vm_life_cycle.py

• test_10_attachAndDetach_iso Failing since 65 runs

• test_routers_network_ops.py

• test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 98 runs

• test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 98 runs

• test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 96 runs

• test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 96 runs

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✔centos7 ✖debian. JID-1291

[yadvr]

@anshul1886 please check/fix build failures

[yadvr]

@anshul1886 ping, can you fix the build failures?

[yadvr]

Ping, any updates? I'll remove this from 4.11 milestone due to lack of engagement and discussions.

[DaanHoogland]

@anshul1886 please rebase and re-open if still relevant