CLOUDSTACK-9690: Scale CentOS7 VM fails with error #1849

sudhansu7 · 2016-12-21T17:45:43Z

Scale CentOS7 VM fails with error "Cannot scale up the vm because of memory constraint violation"

When creating VM from CentOS 7 template on the XenServer with dynamically scaling enabled, instance starts with base specified memory instead of memory * 4 as static limit.

As the result, attempt to scale VM throws error in MS log:

java.lang.RuntimeException: Job failed due to exception Unable to scale vm due to Catch exception com.cloud.utils.exception.CloudRuntimeException when scaling VM:i-24-3976-VM due to com.cloud.utils.exception.CloudRuntimeException: Cannot scale up the vm because of memory constraint violation: 0 <= memory-static-min(2147483648) <= memory-dynamic-min(8589934592) <= memory-dynamic-max(8589934592) <= memory-static-max(2147483648)

REPO STEPS

Enable dynamic scaling in Global settings

Register an CentOS 7 tempplate(with tools) and tick dynamic scaling

```
Deploy VM with this template
```

Start the VM and try to change service offering

EXPECTED RESULT: VM should start with static limit 4x and scale up when offering is changed
ACTUAL RESULT: VM starts with maximum static limit of and doesn't scale up with error in ms log :
Cannot scale up the vm because of memory constraint violation:

Root Cause: Xensever guest OS memory values are missing for 'CentOS 7'.

Solution: Add Xensever guest OS memory values for 'CentOS 7'. But this needs patching and restart of management server. In this fix the hardcoded values are moved from Java files to database.

Removed XenServerGuestOsMemoryMap from CitrixHelper.java
This java file was holding a static in memory map named XenServerGuestOsMemoryMap. This was the source for xenserver dynamic memory values(max and min). These values were moved to guest_os_details table.
DAO layer was modified to access these values.
VirtualMachineTo object was modified to populate the dynamic memory values.
addGuestOs and UpdateGuestOS api has been modified to update memory values.

yadvr · 2016-12-22T06:22:39Z

api/src/com/cloud/agent/api/to/VirtualMachineTO.java

    String configDriveIsoRootFolder = null;
    String configDriveIsoFile = null;

+    Map<String, String> guestOsDetails = null;


To avoid potential NPEs, construct a hashmap with no items, such as
Map<String, String> guestOsDetails = new Hashmap();

yadvr · 2016-12-22T06:23:15Z

api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java

    }

+    public Map getDetails() {
+        Map<String, String> detailsMap = null;


don't make getDetails return null, instead return an empty hashmap.

yadvr · 2016-12-22T06:23:38Z

api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsCmd.java

    }

+    public Map getDetails() {
+        Map<String, String> detailsMap = null;


don't make getDetails return null, instead return an empty hashmap.

sudhansu7 · 2016-12-22T19:37:31Z

@rhtyd Thanks for the Review. I have amended the code as per your suggestion.

karuturi · 2016-12-30T06:05:02Z

@blueorangutan package

blueorangutan · 2016-12-30T06:06:03Z

@karuturi a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2016-12-30T06:48:39Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-436

karuturi · 2016-12-30T08:44:53Z

@blueorangutan test centos7 xenserver-65sp1

cloudmonger · 2017-03-02T19:24:23Z

ACS CI BVT Run

Sumarry:
Build Number 414
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=0
Skipped=7

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

Skipped tests:
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py

jayakarteek · 2017-04-04T12:05:09Z

@sudhansu7

Tested the fix, LGTM.
I am able to change from small computer offering to medium computer offering for centos-7.

jayantpatil1234 · 2017-04-04T12:31:32Z

@sudhansu7
There is one file "Upgrade4910to4920.java", which does not have any changes, still that get added in PR. If possible could you remove that file?

Otherwise code looks good. LGTM for code.

karuturi · 2017-04-22T15:36:54Z

@sudhansu7 can you address @jayantpatil1234's comment?

1. Removed XenServerGuestOsMemoryMap from CitrixHelper.java This java file was holding a static in memory map named XenServerGuestOsMemoryMap. This was the source for xenserver dynamic memory values(max and min). These values were moved to guest_os_details table. 2. DAO layer was modified to access these values. 3. VirtualMachineTo object was modified to populate the dynamic memory values. 4. addGuestOs and UpdateGuestOS api has been modified to update memory values.

sudhansu7 · 2017-05-05T05:31:16Z

@jayantpatil1234, I have removed Upgrade4910to4920.java from commit.

sudhansu7 · 2017-05-05T05:32:27Z

tag:mergeready

sudhansu7 force-pushed the CLOUDSTACK-9690 branch from 60021de to 327f7c2 Compare December 22, 2016 05:58

yadvr reviewed Dec 22, 2016

View reviewed changes

sudhansu7 force-pushed the CLOUDSTACK-9690 branch from 327f7c2 to 2f5a6b3 Compare December 22, 2016 14:56

sudhansu7 force-pushed the CLOUDSTACK-9690 branch from 2f5a6b3 to b288b3c Compare February 26, 2017 14:14

sudhansu7 force-pushed the CLOUDSTACK-9690 branch from b288b3c to 992fac4 Compare March 31, 2017 07:42

karuturi added 4.10.0.0 status:waiting-for-author labels Apr 25, 2017

karuturi modified the milestone: 4.10.0.0 Apr 27, 2017

karuturi removed the 4.10.0.0 label Apr 27, 2017

sudhansu7 force-pushed the CLOUDSTACK-9690 branch from 992fac4 to e7a7db3 Compare May 5, 2017 05:29

luhaijiao mentioned this pull request May 9, 2017

Honor network.dns.basiczone.updates setting when sending DHCP config … #2077

Merged

karuturi removed the status:waiting-for-author label May 16, 2017

karuturi merged commit a4f3c71 into apache:master May 16, 2017

CLOUDSTACK-9690: Scale CentOS7 VM fails with error #1849

CLOUDSTACK-9690: Scale CentOS7 VM fails with error #1849

Uh oh!

Conversation

sudhansu7 commented Dec 21, 2016

REPO STEPS

Uh oh!

yadvr Dec 22, 2016

Choose a reason for hiding this comment

Uh oh!

yadvr Dec 22, 2016

Choose a reason for hiding this comment

Uh oh!

yadvr Dec 22, 2016

Choose a reason for hiding this comment

Uh oh!

sudhansu7 commented Dec 22, 2016

Uh oh!

karuturi commented Dec 30, 2016

Uh oh!

blueorangutan commented Dec 30, 2016

Uh oh!

blueorangutan commented Dec 30, 2016

Uh oh!

karuturi commented Dec 30, 2016

Uh oh!

cloudmonger commented Mar 2, 2017

ACS CI BVT Run

Uh oh!

jayakarteek commented Apr 4, 2017

Uh oh!

jayantpatil1234 commented Apr 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

karuturi commented Apr 22, 2017

Uh oh!

sudhansu7 commented May 5, 2017

Uh oh!

sudhansu7 commented May 5, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jayantpatil1234 commented Apr 4, 2017 •

edited

Loading