Skip to content

Boot into hardware setup menu on Vmware #4021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DaanHoogland merged 33 commits into from
Jun 11, 2020
Merged

Boot into hardware setup menu on Vmware #4021

DaanHoogland merged 33 commits into from
Jun 11, 2020

Conversation

@DaanHoogland
Copy link
Contributor

@DaanHoogland DaanHoogland commented Apr 7, 2020 •
edited by yadvr
Loading

Description

allow VMs to be started into BIOS on Vmware. This is implemented in the reboot, start and deploy APIs for user VMs.

Related Primate PR: apache/cloudstack-primate#313

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

image

image

Screenshot 2020-04-27 at 17 13 06

A primate PR has been created with number 313

How Has This Been Tested?

this has been manually verified by means of API/old-UI/primate and checking if the boot menu would then be visible or not depending on the flag passed.

@DaanHoogland DaanHoogland mentioned this pull request Apr 7, 2020
Closed
5 tasks
@apache apache deleted a comment from blueorangutan Apr 7, 2020
@apache apache deleted a comment from blueorangutan Apr 7, 2020
@apache apache deleted a comment from blueorangutan Apr 7, 2020
@apache apache deleted a comment from blueorangutan Apr 7, 2020
@apache apache deleted a comment from blueorangutan Apr 7, 2020
@apache apache deleted a comment from blueorangutan Apr 7, 2020
@DaanHoogland DaanHoogland force-pushed the bootIntoBios branch 2 times, most recently from 7b4f5c9 to 8f68612 Compare April 7, 2020 15:08
@apache apache deleted a comment from blueorangutan Apr 7, 2020
@DaanHoogland DaanHoogland force-pushed the bootIntoBios branch 2 times, most recently from 447a96c to 7e333a2 Compare April 8, 2020 12:40
@apache apache deleted a comment from blueorangutan Apr 10, 2020
@apache apache deleted a comment from blueorangutan Apr 10, 2020
@apache apache deleted a comment from blueorangutan Apr 10, 2020
@apache apache deleted a comment from blueorangutan Apr 17, 2020
@apache apache deleted a comment from blueorangutan Apr 17, 2020
@apache apache deleted a comment from blueorangutan Apr 17, 2020
@apache apache deleted a comment from blueorangutan Apr 17, 2020
@apache apache deleted a comment from blueorangutan Apr 17, 2020
@apache apache deleted a comment from blueorangutan Apr 20, 2020
@apache apache deleted a comment from blueorangutan Apr 20, 2020
@apache apache deleted a comment from blueorangutan Apr 21, 2020
@apache apache deleted a comment from blueorangutan Apr 21, 2020
@apache apache deleted a comment from blueorangutan Apr 22, 2020
@apache apache deleted a comment from blueorangutan Apr 23, 2020
@svenvogel
Copy link
Contributor

svenvogel commented Apr 23, 2020

@DaanHoogland do you think it could be used to extend it for KVM?

@DaanHoogland
Copy link
Contributor Author

DaanHoogland commented Apr 23, 2020 •
edited
Loading

bootintobios does not make sense for KVM as you can edit the xml for setup @svenvogel. I have not looked into that, yet. Same is claimed for xen btw. It might make sense for some of the smaller hypervisors.

@blueorangutan
Copy link

blueorangutan commented Jun 4, 2020

Packaging result: ✔centos7 ✔debian. JID-1294

@yadvr
Copy link
Member

yadvr commented Jun 4, 2020

@blueorangutan test centos7 vmware-67u3

@blueorangutan
Copy link

blueorangutan commented Jun 4, 2020

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jun 5, 2020

Trillian test result (tid-1626)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 55070 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4021-t1626-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_07_reboot_ssvm Failure 42.20 test_ssvm.py

borisstoyanov
borisstoyanov approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaanHoogland DaanHoogland merged commit 0795cd4 into apache:master Jun 11, 2020
@DaanHoogland DaanHoogland deleted the bootIntoBios branch June 11, 2020 11:47
yadvr added a commit to apache/cloudstack-primate that referenced this pull request Jun 16, 2020
@DaanHoogland @shwstppr @yadvr
compute: VMware Bootintobios (#313)
e606fe9 
UI implementation for apache/cloudstack#4021

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
andrijapanicsb
andrijapanicsb reviewed Jun 22, 2020
View reviewed changes
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
UserVm userVm = rebootVirtualMachine(CallContext.current().getCallingUserId(), vmId);
Boolean enterSetup = cmd.getBootIntoSetup();
if (enterSetup != null && !HypervisorType.VMware.equals(vmInstance.getHypervisorType())) {
throw new InvalidParameterValueException("booting into a hardware setup menu does not make sense on " + vmInstance.getHypervisorType());
Copy link
Contributor

@andrijapanicsb andrijapanicsb Jun 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this message, missing capital "B" and in general I don't like it... can we reword it to "...not supported for ...." or similar?

Copy link
Contributor Author

@DaanHoogland DaanHoogland Jun 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yes we can but a new re-word PR is needed.

@yadvr
Copy link
Member

yadvr commented Jul 14, 2020

This or any of the VMware related PRs may have introduced some regression due to consistently failing test test_07_reboot_ssvm :( let's fix that soon irrespective of what/who caused this cc @DaanHoogland

weizhouapache pushed a commit to apache/cloudstack-primate that referenced this pull request Jan 19, 2021
@DaanHoogland @shwstppr
@yadvr @ustcweizhou
compute: VMware Bootintobios (#313)
914e01f 
UI implementation for apache/cloudstack#4021

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr added a commit that referenced this pull request Jan 20, 2021
@DaanHoogland @shwstppr @yadvr
compute: VMware Bootintobios (#313)
2490b5d 
UI implementation for #4021

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrijapanicsb andrijapanicsb andrijapanicsb left review comments

@yadvr yadvr yadvr approved these changes

@nvazquez nvazquez nvazquez approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

@PaulAngus PaulAngus Awaiting requested review from PaulAngus

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

Assignees

No one assigned

Labels

component:vmware type:enhancement

Projects

None yet

Milestone

4.15.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@DaanHoogland @svenvogel @blueorangutan @borisstoyanov @yadvr @nvazquez @andrijapanicsb