Skip to content

CLOUDSTACK-8572:Unable to deploy VM as no storage pool found in UP state #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pritisarap12 wants to merge 1 commit into from
Closed

CLOUDSTACK-8572:Unable to deploy VM as no storage pool found in UP state #480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions test/integration/testpaths/testpath_vmlc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,19 @@ def setUpClass(cls):
cls.zone = get_zone(cls.apiclient)
cls._cleanup = []

cls.skiptest = False
Copy link

@gauravaradhye gauravaradhye Jun 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this test require any special storage pool? or with any tags? If not, there is no reason to add this check as it is expected that storage pool is present in setup.

Copy link
Author

@pritisarap12 pritisarap12 Jun 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test does not require any special storage pool or with any tags. This check was put since it did not find any storage pool in UP state.i.e storage pool was present but was not in UP state.
So should I remove the check for skipTest?

Copy link

@gauravaradhye gauravaradhye Jun 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need for these checks. Instead the tests which leave the storage pool in disabled state should be looked at. Hold it for now.

cls.skiptest_reason = ""

cls.pools = StoragePool.list(cls.apiclient, zoneid=cls.zone.id)
if not cls.pools:
cls.skiptest = True
cls.skiptest_reason = "No Storage Pools available in setup."
else:
for storagePool in cls.pools:
if storagePool.state.lower() != UP:
cls.skiptest = True
cls.skiptest_reason = "No Storage Pools available in UP State in setup."

try:
# Create an account
cls.account = Account.create(
Expand Down Expand Up @@ -299,6 +312,10 @@ def tearDownClass(cls):
raise Exception("Warning: Exception during cleanup : %s" % e)

def setUp(self):
if self.skiptest:
self.skipTest(
"Skipping Test : %s" % self.skiptest_reason)

self.apiclient = self.testClient.getApiClient()
self.cleanup = []

Expand Down