Skip to content

Conversation

@nvazquez
Copy link
Contributor

@nvazquez nvazquez commented Sep 7, 2021

Description

This PR uses the host name if the host IP is not found on Vmware for Vmware 7 console proxy websocket URL
Fixes: #5413

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@nvazquez
Copy link
Contributor Author

nvazquez commented Sep 7, 2021

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1151

@nvazquez
Copy link
Contributor Author

nvazquez commented Sep 8, 2021

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1152

@yadvr
Copy link
Member

yadvr commented Sep 8, 2021

@blueorangutan test centos7 vmware-67u3

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@yadvr
Copy link
Member

yadvr commented Sep 8, 2021

@blueorangutan test centos7 vmware-70

@blueorangutan
Copy link

@rhtyd unsupported parameters provided. Supported mgmt server os are: centos7, centos6, alma8, ubuntu18, suse15, ubuntu20, rocky8, centos8. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-centos8, kvm-rocky8, kvm-alma8, kvm-ubuntu18, kvm-ubuntu20, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82

return false;
}

private String getHostFqdn(HostMO hostMO, String hostName) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvazquez I think, it is better to keep this method in HostMO.

public String getHostFqdn() {
        try {
             HostDnsConfig hostDnsConfig = getHostNetworkInfo().getDnsConfig();
             return String.format("%s.%s", hostDnsConfig.getHostName(), hostDnsConfig.getDomainName());
         } catch (Exception e) {
             s_logger.error("Could not get host FQDN for host: " + getHostName());
         }
         return null;
}

@nvazquez
Copy link
Contributor Author

nvazquez commented Sep 8, 2021

I'm closing this in favour of #5419

@nvazquez nvazquez closed this Sep 8, 2021
@blueorangutan
Copy link

Trillian test result (tid-1988)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39607 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5414-t1988-vmware-67u3.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@nvazquez nvazquez deleted the vmware7consolefqdn branch February 12, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Console Proxy & VMware 7 websocket issue

4 participants