Skip to content

server: honor global setting system.vm.default.hypervisor as first option when deploy VRs #6160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nvazquez merged 1 commit into from
Apr 13, 2022
Merged

server: honor global setting system.vm.default.hypervisor as first option when deploy VRs #6160

nvazquez merged 1 commit into from
Apr 13, 2022

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Mar 23, 2022 •
edited by nvazquez
Loading

Description

This PR fixes #6084

The global setting system.vm.default.hypervisor will be the first option when deploy VRs.
If it is not set, use the hypervisor type of cluster as 2nd option.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache
Copy link
Member Author

weizhouapache commented Mar 23, 2022

@blueorangutan package

@weizhouapache weizhouapache linked an issue Mar 23, 2022 that may be closed by this pull request
router service offering tags are not honored #6084
Closed
@nvazquez nvazquez added this to the 4.17.0.0 milestone Mar 23, 2022
@nvazquez
Copy link
Contributor

nvazquez commented Mar 23, 2022

@blueorangutan package

nvazquez
nvazquez approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@weizhouapache
Copy link
Member Author

weizhouapache commented Mar 23, 2022

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Mar 23, 2022

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 23, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2969

@nvazquez
Copy link
Contributor

nvazquez commented Mar 23, 2022

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Mar 23, 2022

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Mar 24, 2022

Trillian test result (tid-3708)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37228 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6160-t3708-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_disable_oobm_ha_state_ineligible Error 1511.94 test_hostha_kvm.py

yadvr
yadvr approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but needs testing. @weizhouapache pl check if a marvin test covers this case; otherwise a new test case maybe added or manual test confirmation needed.

@weizhouapache
Copy link
Member Author

weizhouapache commented Mar 24, 2022

LGTM - but needs testing. @weizhouapache pl check if a marvin test covers this case; otherwise a new test case maybe added or manual test confirmation needed.

@rohityadavcloud
thanks for review.
I have manually tested it, but it would be good if someone else test it as well. cc @borisstoyanov @nvazquez

marvin test looks difficult because all hosts have same hypervisor type in each trillian environment.

@weizhouapache
Copy link
Member Author

weizhouapache commented Mar 29, 2022

@blueorangutan test

@weizhouapache weizhouapache reopened this Mar 29, 2022
@nvazquez
Copy link
Contributor

nvazquez commented Apr 5, 2022

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Apr 5, 2022

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Apr 5, 2022

Trillian test result (tid-3812)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31114 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6160-t3812-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@yadvr
Copy link
Member

yadvr commented Apr 8, 2022

Are we waiting on Bobby's review/testing @weizhouapache @nvazquez ?

1 similar comment
@yadvr
Copy link
Member

yadvr commented Apr 8, 2022

Are we waiting on Bobby's review/testing @weizhouapache @nvazquez ?

@nvazquez nvazquez marked this pull request as draft April 8, 2022 10:58
@nvazquez
Copy link
Contributor

nvazquez commented Apr 8, 2022

Yes @rohityadavcloud - with @borisstoyanov for testing

NuxRo
NuxRo approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@NuxRo NuxRo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@weizhouapache weizhouapache marked this pull request as ready for review April 13, 2022 10:12
@nvazquez nvazquez merged commit 91a5f0e into apache:4.16 Apr 13, 2022
@weizhouapache weizhouapache mentioned this pull request Apr 13, 2022
Closed
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @yadvr
server: honor global setting system.vm.default.hypervisor as first op…
fd79618 
…tion when deploy VRs (apache#6160)

(cherry picked from commit 91a5f0e)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @yadvr
server: honor global setting system.vm.default.hypervisor as first op…
a131009 
…tion when deploy VRs (apache#6160)

(cherry picked from commit 91a5f0e)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @yadvr
server: honor global setting system.vm.default.hypervisor as first op…
769ed8f 
…tion when deploy VRs (apache#6160)

(cherry picked from commit 91a5f0e)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @yadvr
server: honor global setting system.vm.default.hypervisor as first op…
5446e32 
…tion when deploy VRs (apache#6160)

(cherry picked from commit 91a5f0e)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @yadvr
server: honor global setting system.vm.default.hypervisor as first op…
c2e37f2 
…tion when deploy VRs (apache#6160)

(cherry picked from commit 91a5f0e)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
RodrigoDLopez pushed a commit to RodrigoDLopez/cloudstack that referenced this pull request Aug 23, 2022
Port of PR apache#6160
cd188b4
RodrigoDLopez pushed a commit to RodrigoDLopez/cloudstack that referenced this pull request Aug 23, 2022
Merge branch 'port-pr-6160' into '4.16.0.0-scclouds'
29a2bab 
Port of PR apache#6160

Closes apache#486

See merge request scclouds/scclouds!237
@weizhouapache weizhouapache deleted the 4.16-honor-system.vm.default.hypervisor branch December 9, 2022 08:34
@weizhouapache weizhouapache mentioned this pull request Apr 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@NuxRo NuxRo NuxRo approved these changes

@nvazquez nvazquez nvazquez approved these changes

@sureshanaparti sureshanaparti Awaiting requested review from sureshanaparti

@borisstoyanov borisstoyanov Awaiting requested review from borisstoyanov

Assignees

@NuxRo NuxRo

@borisstoyanov borisstoyanov

Labels

component:virtual-router type:bug

Projects

No open projects
Apache CloudStack 4.17.0
Status: Done

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

router service offering tags are not honored

6 participants

@weizhouapache @nvazquez @blueorangutan @yadvr @NuxRo @borisstoyanov