Fix deploy from ISO with custom disk offering

[nvazquez]

Description

This PR fixes deploy from ISO with a custom disk offering, the size parameter is not honoured
Fixes: #6440

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Deploy VM from ISO - select custom disk offering
Deploy VM from template - select custom data disk offering

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[nvazquez]

Removing the blocker tag, since there are 2 workarounds:

• Pass the 'rootdisksize' parameter to the deployVM API
• Use a fixed offering with the expected size

[sureshanaparti]

Verified fix, LGTM.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Pearl1594]

Verified. LGTM

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3533

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-4302)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39399 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6441-t4302-kvm-centos7.zip
Smoke tests completed. 96 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	Failure	456.48	test_vpc_redundant.py

[bugoff]

Hi, is it possible this issue still exists for templates? Do you want me to create a new issue for this?