Skip to content

UI: fix diskofferingstrictness is not passed when create compute offering#7072

Merged
DaanHoogland merged 1 commit intoapache:4.17from
weizhouapache:4.17-issue-7070
Jan 12, 2023
Merged

UI: fix diskofferingstrictness is not passed when create compute offering#7072
DaanHoogland merged 1 commit intoapache:4.17from
weizhouapache:4.17-issue-7070

Conversation

@weizhouapache
Copy link
Member

Description

This PR fixes #7070

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #7072 (518ee5a) into 4.17 (5b9a989) will increase coverage by 0.00%.
The diff coverage is 41.30%.

@@            Coverage Diff            @@
##               4.17    #7072   +/-   ##
=========================================
  Coverage     10.36%   10.37%           
- Complexity     6635     6644    +9     
=========================================
  Files          2453     2453           
  Lines        242385   242406   +21     
  Branches      37927    37932    +5     
=========================================
+ Hits          25134    25146   +12     
- Misses       214147   214152    +5     
- Partials       3104     3108    +4     
Impacted Files Coverage Δ
.../main/java/com/cloud/network/NetworkModelImpl.java 9.92% <0.00%> (ø)
...ervisor/kvm/resource/LibvirtComputingResource.java 15.74% <16.66%> (-0.25%) ⬇️
...in/java/com/cloud/server/ManagementServerImpl.java 3.08% <45.45%> (+0.57%) ⬆️
...in/java/com/cloud/host/dao/HostDetailsDaoImpl.java 20.68% <50.00%> (+3.38%) ⬆️
...apache/cloudstack/syslog/AlertsSyslogAppender.java 56.49% <0.00%> (-2.26%) ⬇️
...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 61.94% <0.00%> (-0.36%) ⬇️
...ema/src/main/java/com/cloud/vm/UserVmDetailVO.java 55.55% <0.00%> (+5.55%) ⬆️
.../schema/src/main/java/com/cloud/host/DetailVO.java 69.23% <0.00%> (+53.84%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no issues, but is something from another PR leaking in?

@github-actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@github-actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Copy link
Member

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaanHoogland DaanHoogland added this to the 4.18.0.0 milestone Jan 12, 2023
@DaanHoogland DaanHoogland merged commit 4d80ea6 into apache:4.17 Jan 12, 2023
@weizhouapache weizhouapache deleted the 4.17-issue-7070 branch January 30, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI add compute offering wizard missing parameter diskofferingstrictness in api call

3 participants