Skip to content

Conversation

@nvazquez
Copy link
Contributor

@nvazquez nvazquez commented Feb 3, 2023

Description

This PR continues the work introduced on PR #5579

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5510

@blueorangutan
Copy link

Trillian Build Failed (tid-6127)

@DaanHoogland
Copy link
Contributor

just for form, (might not wait for results if manual tests are as good as they look so far)
@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-6132)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41407 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7166-t6132-kvm-centos7.zip
Smoke tests completed. 107 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@boring-cyborg boring-cyborg bot added the Python Warning... Python code Ahead! label Feb 9, 2023
@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5541

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, tested with tungsten disabled, no regressions noticed

@blueorangutan
Copy link

Trillian test result (tid-6148)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40688 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7166-t6148-kvm-centos7.zip
Smoke tests completed. 105 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_deploy_vm_with_extraconfig_kvm Error 0.17 test_deploy_vm_extra_config_data.py
test_03_update_vm_with_extraconfig_kvm Error 1.21 test_deploy_vm_extra_config_data.py
test_02_deploy_vm_on_specific_cluster Error 1.16 test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod Error 0.18 test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster Error 1.19 test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod Error 1.19 test_vm_deployment_planner.py

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes LGTM. Some focus related changes in unrelated views could be in a separate PR but a minor thing

@DaanHoogland DaanHoogland merged commit c44ba8f into main Feb 10, 2023
@nvazquez nvazquez deleted the pr/5579 branch February 15, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:UI Python Warning... Python code Ahead!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants