remove supportedOwner from Resource.ResourceType

[GaOrtiga]

Description

The ResourceType enum, which is part of the Resource interface, includes an argument called supportedOwners that is used to indicate which types of owners are supported - either Domain, Account or both. However, every type of owner enumerated is supported by both options, making this validation unnecessary.

This argument has been removed, along with its getter method.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[DaanHoogland]

clgtm

[codecov]

Codecov Report

Merging #7416 (59dab74) into main (729e6d1) will decrease coverage by 0.73%.
Report is 126 commits behind head on main.
The diff coverage is 0.00%.

❗ Current head 59dab74 differs from pull request most recent head e21df9f. Consider uploading reports for the commit e21df9f to get more accurate results

@@             Coverage Diff              @@
##               main    #7416      +/-   ##
============================================
- Coverage     13.42%   12.69%   -0.73%     
+ Complexity     9381     8664     -717     
============================================
  Files          2747     2718      -29     
  Lines        258798   256332    -2466     
  Branches      40312    39954     -358     
============================================
- Hits          34732    32539    -2193     
+ Misses       219695   219657      -38     
+ Partials       4371     4136     -235     

Files Changed	Coverage Δ
.../cloud/configuration/dao/ResourceCountDaoImpl.java	9.43% <ø> (+0.58%)	⬆️
.../cloud/resourcelimit/ResourceLimitManagerImpl.java	1.09% <0.00%> (+0.06%)	⬆️
...java/com/cloud/server/ConfigurationServerImpl.java	2.32% <0.00%> (+0.02%)	⬆️

... and 246 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[GaOrtiga]

Thanks for reviewing @DaanHoogland.

Could anyone else review this one?

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[GaOrtiga]

@GutoVeronezi @weizhouapache
Could you guys review this one?

[GutoVeronezi]

CLGTM

Thansk @GaOrtiga

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6920

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-7592)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37247 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7416-t7592-kvm-centos7.zip
Smoke tests completed. 110 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestVmAutoScaling>:setup	Error	0.00	test_vm_autoscaling.py
test_05_vmschedule_test_e2e	Failure	270.49	test_vm_schedule.py
test_02_cancel_host_maintenace_with_migration_jobs	Error	0.40	test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure	Error	0.54	test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connected	Failure	53.70	test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connected	Failure	20.46	test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected	Failure	31.43	test_host_maintenance.py

[GaOrtiga]

I checked the tests and they are not related to my PR; they are failing in other PRs as well, like in this and this. @weizhouapache are we good to go?

[weizhouapache]

I checked the tests and they are not related to my PR; they are failing in other PRs as well, like in this and this. @weizhouapache are we good to go?

@GaOrtiga
code lgtm

However, I do not know why the original author added the code (>10 years ago), and if it will be used in the future.
I will leave to the community to determine if they can be removed.

[GaOrtiga]

Thanks for the review @weizhouapache

However, I do not know why the original author added the code (>10 years ago), and if it will be used in the future. I will leave to the community to determine if they can be removed.

I do not know the original author's intentions either. However, it has never been used and there are no immediate plans to use it, so as of now it is useless code. In my opinion this should be removed, and, if at some point in the future a feature is implemented which uses these parameters, they can just be added back in.

[DaanHoogland]

@weizhouapache (cc @GaOrtiga ) I think that this code can be removed. Nobody is using it and we have a version control system so we can always put it back.

[weizhouapache]

@weizhouapache (cc @GaOrtiga ) I think that this code can be removed. Nobody is using it and we have a version control system so we can always put it back.

ok, fair @DaanHoogland

[weizhouapache]

code lgtm