Skip to content

Improved concatenation way in PropertiesStorage.java #7486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 5 commits into from
Nov 16, 2023
Merged

Improved concatenation way in PropertiesStorage.java #7486

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f70061b
[MINOR][Enhancement] Update PropertiesStorage.java
nikam14 May 2, 2023
5c5f698
changed to String.format
nikam14 May 9, 2023
0434fb2
Apply (trivial) suggestions from code review
DaanHoogland Oct 31, 2023
4186baf
Update agent/src/main/java/com/cloud/agent/dao/impl/PropertiesStorage…
DaanHoogland Nov 15, 2023
76666bb
Update agent/src/main/java/com/cloud/agent/dao/impl/PropertiesStorage…
DaanHoogland Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions agent/src/main/java/com/cloud/agent/dao/impl/PropertiesStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,14 @@ public synchronized boolean configure(String name, Map<String, Object> params) {
file = new File(path);
try {
if (!file.createNewFile()) {
s_logger.error("Unable to create _file: " + file.getAbsolutePath());
s_logger.error(String.format("Unable to create _file: %s", file.getAbsolutePath()));
return false;
}
} catch (IOException e) {
s_logger.error("Unable to create _file: " + file.getAbsolutePath(), e);
s_logger.error(String.format("Unable to create file: %s", file.getAbsolutePath()));
if (s_logger.isDebugEnabled()) {
s_logger.debug(String.format("IOException while trying to create file: %s", file.getAbsolutePath()), e);
}
return false;
}
}
Expand Down