updated the api documentation for createNetworkOffering and updateNetworkOffering #7545

kiranchavala · 2023-05-23T07:34:33Z

…workOffering

Description

This PR fixes #7510

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
[ X ] Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
[ X ] Minor

Bug Severity

BLOCKER
Critical
Major
Minor
[ X ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

…workOffering

andrijapanicsb · 2023-05-23T08:55:10Z

@blueorangutan LLpackage (testing LL build jobs <----- ignore this)

blueorangutan · 2023-05-23T08:56:03Z

@andrijapanicsb a [LL] Jenkins job has been kicked to build packages. It will be bundled with (testing LL build jobs <----- ignore this) SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan · 2023-05-23T09:00:29Z

Packaging result [LL]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 6048

andrijapanicsb · 2023-05-23T09:03:32Z

@blueorangutan package

blueorangutan · 2023-05-23T09:04:04Z

@andrijapanicsb a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

andrijapanicsb · 2023-05-23T09:04:15Z

@blueorangutan LLpackage

blueorangutan · 2023-05-23T09:06:03Z

@andrijapanicsb a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-05-23T09:10:42Z

Packaging result [LL]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 6049

blueorangutan · 2023-05-23T09:53:40Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 6122

api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java

api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java

…ork/UpdateNetworkOfferingCmd.java Co-authored-by: dahn <daan.hoogland@gmail.com>

…ork/CreateNetworkOfferingCmd.java Co-authored-by: dahn <daan.hoogland@gmail.com>

weizhouapache

code lgtm

weizhouapache · 2023-08-10T05:47:46Z

@blueorangutan package

blueorangutan · 2023-08-10T05:48:03Z

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-08-10T05:53:01Z

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 6732

api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java

…ork/CreateNetworkOfferingCmd.java remove line trailing

weizhouapache · 2023-08-10T06:37:20Z

@blueorangutan package

blueorangutan · 2023-08-10T06:38:06Z

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-08-10T07:33:49Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6733

codecov · 2023-08-10T07:58:57Z

Codecov Report

Merging #7545 (60877e3) into 4.18 (22871ad) will increase coverage by 13.02%.
Report is 194 commits behind head on 4.18.
The diff coverage is n/a.

❗ Current head 60877e3 differs from pull request most recent head 9cac9c8. Consider uploading reports for the commit 9cac9c8 to get more accurate results

@@             Coverage Diff             @@
##             4.18    #7545       +/-   ##
===========================================
+ Coverage        0   13.02%   +13.02%     
- Complexity      0     9032     +9032     
===========================================
  Files           0     2720     +2720     
  Lines           0   257071   +257071     
  Branches        0    40089    +40089     
===========================================
+ Hits            0    33475    +33475     
- Misses          0   219392   +219392     
- Partials        0     4204     +4204

see 2720 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

weizhouapache · 2023-08-11T08:03:23Z

@blueorangutan test rocky8 kvm-rocky8

api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java

yadvr · 2023-08-22T09:10:29Z

ping @kiranchavala can you review outstanding comments, thanks.

weizhouapache · 2023-08-24T13:03:23Z

moved to 4.18.2.0

api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java

DaanHoogland · 2023-10-02T13:29:48Z

ping @kiranchavala

DaanHoogland · 2023-11-08T13:45:28Z

@weizhouapache @kiranchavala , can you agree with my suggestion?

…ork/UpdateNetworkOfferingCmd.java

DaanHoogland · 2023-11-09T16:07:03Z

only textual changes; mergingĤĤĤĤĤĤĤ build errors :(

* 4.18: updated the api documentation for createNetworkOffering and updateNetworkOffering (#7545)

…workOffering (apache#7545) Co-authored-by: Kiran Chavala <kiranchavala@Kirans-MacBook-Air.local> Co-authored-by: Wei Zhou <weizhou@apache.org> Co-authored-by: dahn <daan.hoogland@gmail.com>

* 4.18: updated the api documentation for createNetworkOffering and updateNetworkOffering (apache#7545)

updated the api documentation for createNetworkOffering and updateNet…

66361f9

…workOffering

boring-cyborg bot added the component:api label May 23, 2023

kiranchavala added the component:documentation label May 23, 2023

yadvr reviewed May 29, 2023

View reviewed changes

api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java Outdated Show resolved Hide resolved

DaanHoogland added this to the 4.18.1.0 milestone Jun 22, 2023

weizhouapache added the Severity:Trivial label Jun 26, 2023

DaanHoogland reviewed Jul 11, 2023

View reviewed changes

api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java Outdated Show resolved Hide resolved

api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java Outdated Show resolved Hide resolved

weizhouapache and others added 2 commits August 10, 2023 07:46

Update api/src/main/java/org/apache/cloudstack/api/command/admin/netw…

e522248

…ork/UpdateNetworkOfferingCmd.java Co-authored-by: dahn <daan.hoogland@gmail.com>

Update api/src/main/java/org/apache/cloudstack/api/command/admin/netw…

79be575

…ork/CreateNetworkOfferingCmd.java Co-authored-by: dahn <daan.hoogland@gmail.com>

weizhouapache approved these changes Aug 10, 2023

View reviewed changes

weizhouapache reviewed Aug 10, 2023

View reviewed changes

api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java Outdated Show resolved Hide resolved

Update api/src/main/java/org/apache/cloudstack/api/command/admin/netw…

60877e3

…ork/CreateNetworkOfferingCmd.java remove line trailing

weizhouapache requested a review from yadvr August 11, 2023 08:03

weizhouapache requested a review from DaanHoogland August 11, 2023 08:03

DaanHoogland reviewed Aug 11, 2023

View reviewed changes

api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java Outdated Show resolved Hide resolved

weizhouapache modified the milestones: 4.18.1.0, 4.18.2.0 Aug 24, 2023

DaanHoogland reviewed Sep 22, 2023

View reviewed changes

api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java Outdated Show resolved Hide resolved

yadvr approved these changes Oct 16, 2023

View reviewed changes

Update api/src/main/java/org/apache/cloudstack/api/command/admin/netw…

9cac9c8

…ork/UpdateNetworkOfferingCmd.java

DaanHoogland closed this Nov 9, 2023

DaanHoogland reopened this Nov 9, 2023

DaanHoogland merged commit 8644480 into apache:4.18 Nov 9, 2023

DaanHoogland mentioned this pull request Nov 9, 2023

Unable to execute updateNetworkOffering api call when availability=Required is passed #7510

Closed

DaanHoogland added a commit that referenced this pull request Nov 10, 2023

Merge release branch 4.18 to main

e7bb89c

* 4.18: updated the api documentation for createNetworkOffering and updateNetworkOffering (#7545)

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Nov 16, 2023

Merge release branch 4.18 to main

74b9b36

* 4.18: updated the api documentation for createNetworkOffering and updateNetworkOffering (apache#7545)

updated the api documentation for createNetworkOffering and updateNetworkOffering #7545

updated the api documentation for createNetworkOffering and updateNetworkOffering #7545

Uh oh!

Conversation

kiranchavala commented May 23, 2023

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

andrijapanicsb commented May 23, 2023

Uh oh!

blueorangutan commented May 23, 2023

Uh oh!

blueorangutan commented May 23, 2023

Uh oh!

andrijapanicsb commented May 23, 2023

Uh oh!

blueorangutan commented May 23, 2023

Uh oh!

andrijapanicsb commented May 23, 2023

Uh oh!

blueorangutan commented May 23, 2023

Uh oh!

blueorangutan commented May 23, 2023

Uh oh!

blueorangutan commented May 23, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Aug 10, 2023

Uh oh!

blueorangutan commented Aug 10, 2023

Uh oh!

blueorangutan commented Aug 10, 2023

Uh oh!

Uh oh!

weizhouapache commented Aug 10, 2023

Uh oh!

blueorangutan commented Aug 10, 2023

Uh oh!

blueorangutan commented Aug 10, 2023

Uh oh!

codecov bot commented Aug 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapache commented Aug 11, 2023

Uh oh!

Uh oh!

yadvr commented Aug 22, 2023

Uh oh!

weizhouapache commented Aug 24, 2023

Uh oh!

Uh oh!

DaanHoogland commented Oct 2, 2023

Uh oh!

DaanHoogland commented Nov 8, 2023

Uh oh!

DaanHoogland commented Nov 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Aug 10, 2023 •

edited

Loading

DaanHoogland commented Nov 9, 2023 •

edited

Loading