server: fix dualstack ipv6 networks for vxlan

[shwstppr]

Description

Fixes #7926

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested dualstack isolated network deployment with an advanced zone (simulator) having VXLAN isolation

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6961

[codecov]

Codecov Report

Merging #7933 (4292444) into 4.18 (89e0a4c) will increase coverage by 0.00%.
Report is 1 commits behind head on 4.18.
The diff coverage is 23.07%.

@@            Coverage Diff            @@
##               4.18    #7933   +/-   ##
=========================================
  Coverage     13.06%   13.06%           
- Complexity     9096     9099    +3     
=========================================
  Files          2720     2720           
  Lines        257462   257466    +4     
  Branches      40145    40145           
=========================================
+ Hits          33634    33646   +12     
+ Misses       219601   219591   -10     
- Partials       4227     4229    +2     

Files Changed	Coverage Δ
.../java/com/cloud/network/guru/GuestNetworkGuru.java	32.08% <9.09%> (-1.11%)	⬇️
.../com/cloud/network/guru/VxlanGuestNetworkGuru.java	56.36% <100.00%> (ø)
...m/cloud/network/guru/ExternalGuestNetworkGuru.java	5.36% <100.00%> (+0.33%)	⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[weizhouapache]

code lgtm

need testing

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-7621)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45377 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7933-t7621-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_unsecure_vm_migration	Error	227.06	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	Error	153.13	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	Error	153.13	test_vm_life_cycle.py

[yadvr]

LGTM didn't test it though

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[weizhouapache]

@blueorangutan LLpackage

[blueorangutan]

@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6987

[blueorangutan]

Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6175

[weizhouapache]

@blueorangutan LLtest matrix

[blueorangutan]

@weizhouapache a [LL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[weizhouapache]

Verified OK

[blueorangutan]

[LL]Trillian test result (tid-6737)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35784 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7933-t6737-xenserver-71.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[blueorangutan]

[LL]Trillian test result (tid-6739)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39599 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7933-t6739-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_cpvm_vm	Failure	0.03	test_ssvm.py
test_04_cpvm_internals	Failure	0.03	test_ssvm.py

[blueorangutan]

[LL]Trillian test result (tid-6738)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 46872 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7933-t6738-vmware-67u3.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deploy_vm_on_specific_host	Error	3602.78	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	Error	1.30	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	Error	4.29	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	Error	4.29	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	Error	18.59	test_vm_deployment_planner.py