KVM Host HA enhancement for StorPool storage #8045
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8045 +/- ##
============================================
- Coverage 29.19% 29.19% -0.01%
- Complexity 31015 31024 +9
============================================
Files 5181 5181
Lines 365255 365434 +179
Branches 53427 53449 +22
============================================
+ Hits 106646 106676 +30
- Misses 243988 244141 +153
+ Partials 14621 14617 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 26 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
@blueorangutan package |
|
@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7244 |
|
@blueorangutan test |
|
@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-7864)
|
|
@slavkap Hi, can you please have a look into the failing Lint GH action? Should this be considered for 4.19? |
|
Hi @shwstppr, I know that there is no time for 4.19, but if possible for 4.19.1, it would be great |
|
Thanks @slavkap. I'm tentatively adding it to 4.19.0 milestone. We can move it later if it doesn't works out. |
shwstppr
requested review from
DaanHoogland,
GutoVeronezi,
nvazquez and
weizhouapache
|
@blueorangutan package |
|
@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
@blueorangutan package |
|
@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7397 |
|
@blueorangutan test |
|
@kiranchavala can you please test any regression with NFS and existing Host HA functionality? |
|
@shwstppr @DaanHoogland to test the host ha with NFS, it is possible only on a physical machine which supports Redfish testing or IPMI tool |
|
@kiranchavala afaik IPMI tool works for testing it. Maybe others can comment better @DaanHoogland @weizhouapache @rohityadavcloud |
|
@kiranchavala see test_hostha_kvm.py and test_outofbandmanagement.py. ipmitool is used in those. |
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7607 |
There was a problem hiding this comment.
LGTM. Testing was performed only to verify that the NFS-based host HA (fencing) still works. Unable to verify with StorPool since the hardware is not available.
Nov 03 09:56:08 pr8045-t8226-kvm-rocky8-kvm1 heartbeat[17466]: kvmheartbeat.sh will reboot system because it was unable to write the heartbeat to the storage.
|
@blueorangutan test |
|
@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Extending the current functionality of KVM Host HA for StorPool storage plugin and option for easy integration for the rest of the storage plugins
Done. Thank you @DaanHoogland, @rajujith and @shwstppr for the reviews and testing! |
|
@blueorangutan package |
|
[SF] Trillian test result (tid-8228)
|
|
Merging based on smoke test results and manual regression test |
|
@slavkap will be great if you can add a note about the functionality in the documentation |
Extending the current functionality of KVM Host HA for the StorPool storage plugin and the option for easy integration for the rest of the storage plugins to support Host HA This extension works like the current NFS storage implementation. It allows it to be used simultaneously with NFS and StorPool storage or only with StorPool primary storage. If it is used with different primary storages like NFS and StorPool, and one of the health checks fails for storage, there is an option to report the failure to the management with the global config kvm.ha.fence.on.storage.heartbeat.failure. By default this option is disabled when enabled the Host HA service will continue with the checks on the host and eventually will fence the host
8 participants
Description
Extending the current functionality of KVM Host HA for the StorPool storage plugin and the option for easy integration for the rest of the storage plugins to support Host HA
This extension works like the current NFS storage implementation. It allows it to be used simultaneously with NFS and StorPool storage or only with StorPool primary storage.
If it is used with different primary storages like NFS and StorPool, and one of the health checks fails for storage, there is an option to report the failure to the management with the global config
kvm.ha.fence.on.storage.heartbeat.failure. By default this option is disabled when enabled the Host HA service will continue with the checks on the host and eventually will fence the hostTypes of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
Environment configuration:
1 Zone
2 Cluster with 2 hosts in each cluster
2 StorPool primary storage (zone-wide)
with and without NFS primary storage (zone-wide)