make sure vmware adapter detail for nic is passed during registering template

[DaanHoogland]

Description

This PR Fixes: #7864

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

debugged in local UI against lab environment.
Note that this is a pure UI change but is dependend on the template being for vmware and thus can not be tested in the qa env (which is simulator only).

[DaanHoogland]

@blueorangutan ui

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Merging #8173 (fbc94bd) into 4.18 (3b11663) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.18    #8173   +/-   ##
=========================================
  Coverage     13.06%   13.07%           
- Complexity     9111     9113    +2     
=========================================
  Files          2720     2720           
  Lines        257592   257592           
  Branches      40158    40158           
=========================================
+ Hits          33663    33674   +11     
+ Misses       219698   219685   -13     
- Partials       4231     4233    +2     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[DaanHoogland]

@blueorangutan ui

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8173 (QA-JID-218)

[DaanHoogland]

@andrijapanicsb , low prio but you want this! ;)

[shwstppr]

Change at line 231 looks good. Rest seems refactoring

[DaanHoogland]

Change at line 231 looks good. Rest seems refactoring

that's right @shwstppr , but the renaming of values to formvalues is because of a name clash that i encountered debugging. The fetchNicAdapterTypes() changes are pure refactoring.

[yadvr]

LGTM - didn't test it though

[rajujith]

@blueorangutan package

[blueorangutan]

@rajujith a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7674

[rajujith]

LGTM. Verified that the NIC Adapter setting 'vmxnet3' input in the template registration form is retained in the template settings.