Skip to content

Conversation

@vishesh92
Copy link
Member

@vishesh92 vishesh92 commented Nov 8, 2023

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - waiting for automated test results

@codecov
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #8199 (ef04813) into main (11b5831) will increase coverage by 12.27%.
Report is 295 commits behind head on main.
The diff coverage is 16.13%.

@@              Coverage Diff              @@
##               main    #8199       +/-   ##
=============================================
+ Coverage     13.10%   25.37%   +12.27%     
- Complexity     9121    26141    +17020     
=============================================
  Files          2720     5181     +2461     
  Lines        257599   365436   +107837     
  Branches      40158    53447    +13289     
=============================================
+ Hits          33747    92737    +58990     
- Misses       219588   259794    +40206     
- Partials       4264    12905     +8641     
Flag Coverage Δ
simulator-marvin-tests 20.21% <16.13%> (?)
uitests 4.50% <ø> (?)
unit-tests 14.81% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...com/cloud/agent/dhcp/DhcpProtocolParserServer.java 0.00% <ø> (ø)
api/src/main/java/com/cloud/agent/api/Command.java 59.25% <ø> (ø)
...rc/main/java/com/cloud/configuration/Resource.java 82.75% <100.00%> (ø)
api/src/main/java/com/cloud/event/EventTypes.java 95.89% <100.00%> (ø)
...main/java/com/cloud/hypervisor/HypervisorGuru.java 100.00% <100.00%> (ø)
api/src/main/java/com/cloud/network/Network.java 79.20% <100.00%> (ø)
.../src/main/java/com/cloud/network/NetworkModel.java 100.00% <100.00%> (ø)
...pi/src/main/java/com/cloud/server/ResourceTag.java 94.82% <100.00%> (ø)
api/src/main/java/com/cloud/storage/Storage.java 68.68% <100.00%> (ø)
api/src/main/java/com/cloud/storage/Volume.java 99.14% <100.00%> (ø)
... and 165 more

... and 3523 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@nvazquez
Copy link
Contributor

nvazquez commented Nov 8, 2023

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@DaanHoogland DaanHoogland reopened this Nov 8, 2023
@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7680

@nvazquez nvazquez merged commit d3917ef into apache:main Nov 8, 2023
@DaanHoogland DaanHoogland deleted the remove-powermock-from-vmmanager-test branch November 9, 2023 09:06
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants