-
Notifications
You must be signed in to change notification settings - Fork 1.3k
UI: fix scale vm if first disk offering is dymamic #8213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report
@@ Coverage Diff @@
## 4.18 #8213 +/- ##
=============================================
+ Coverage 13.10% 29.11% +16.01%
- Complexity 9121 30982 +21861
=============================================
Files 2720 5186 +2466
Lines 257599 365756 +108157
Branches 40158 53490 +13332
=============================================
+ Hits 33747 106480 +72733
- Misses 219588 244678 +25090
- Partials 4264 14598 +10334
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3787 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
UI build: ✔️ |
Pearl1594
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested - LGTM
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLGTM


Description
This PR fixes #8212
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?