Skip to content

Conversation

@weizhouapache
Copy link
Member

Description

This PR fixes #8212

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache changed the base branch from main to 4.18 November 10, 2023 10:18
@weizhouapache
Copy link
Member Author

screenshot

prior to this PR
image

with this PR
image

@weizhouapache
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #8213 (33c3660) into 4.18 (e790047) will increase coverage by 16.01%.
Report is 1 commits behind head on 4.18.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##               4.18    #8213       +/-   ##
=============================================
+ Coverage     13.10%   29.11%   +16.01%     
- Complexity     9121    30982    +21861     
=============================================
  Files          2720     5186     +2466     
  Lines        257599   365756   +108157     
  Branches      40158    53490    +13332     
=============================================
+ Hits          33747   106480    +72733     
- Misses       219588   244678    +25090     
- Partials       4264    14598    +10334     
Flag Coverage Δ
simulator-marvin-tests 25.05% <ø> (?)
uitests 4.50% <0.00%> (?)
unit-tests 14.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ommand/admin/network/CreateNetworkOfferingCmd.java 70.52% <ø> (ø)
...ommand/admin/network/UpdateNetworkOfferingCmd.java 51.66% <ø> (ø)
ui/src/views/compute/ScaleVM.vue 0.00% <0.00%> (ø)

... and 3787 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8213 (QA-JID-226)

Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - LGTM

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@DaanHoogland DaanHoogland added this to the 4.18.2.0 milestone Nov 10, 2023
@DaanHoogland DaanHoogland merged commit b79e393 into apache:4.18 Nov 10, 2023
@DaanHoogland DaanHoogland deleted the 4.18-fix-scale-vm branch November 10, 2023 13:15
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Scale vm failed if the first disk offering is customized

4 participants