Include domain and account field for createTemplate UI form#8257
Merged
shwstppr merged 2 commits intoapache:mainfrom Nov 28, 2023
sudo87:domainIdTemplate
Merged
Include domain and account field for createTemplate UI form#8257shwstppr merged 2 commits intoapache:mainfrom sudo87:domainIdTemplate
shwstppr merged 2 commits intoapache:mainfrom
sudo87:domainIdTemplate
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8257 +/- ##
============================================
+ Coverage 29.16% 29.17% +0.01%
- Complexity 31064 31081 +17
============================================
Files 5193 5193
Lines 366292 366320 +28
Branches 53555 53559 +4
============================================
+ Hits 106816 106872 +56
+ Misses 244832 244813 -19
+ Partials 14644 14635 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
approved these changes
Nov 27, 2023
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
CLGTM
checked in qa with two different domains/users
shwstppr
approved these changes
Nov 28, 2023
Contributor
shwstppr
left a comment
shwstppr
left a comment
There was a problem hiding this comment.
Tested with a simulator env,
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Nov 29, 2023
…#8257) This PR includes Domain and Account parameters in CreateTemplate form in UI for Admin account. It will expose optional parameters domainId and account in UI supported by createTemplate API apache#8210
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes Domain and Account parameter in CreateTemplate form in UI for Admin account.
It will expose optional parameters domainId and account in UI supported by createTemplate API #8210
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?