Skip to content

Improvement: management server peer states #9885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadvr merged 9 commits into from
Dec 2, 2024

mgmt: change Service IP to Management IP

880c3d9
Select commit
Loading
Failed to load commit list.
Merged

Improvement: management server peer states #9885

mgmt: change Service IP to Management IP
880c3d9
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Nov 30, 2024 in 0s

15.98% (+0.17%) compared to f7b7339

View this Pull Request on Codecov

15.98% (+0.17%) compared to f7b7339

Details

Codecov Report

Attention: Patch coverage is 0% with 231 lines in your changes missing coverage. Please review.

Project coverage is 15.98%. Comparing base (f7b7339) to head (880c3d9).
Report is 21 commits behind head on 4.20.

Files with missing lines Patch % Lines
.../cloud/cluster/ManagementServerHostPeerJoinVO.java 0.00% 60 Missing ⚠️
...ain/java/com/cloud/cluster/ClusterManagerImpl.java 0.00% 50 Missing ⚠️
...api/response/PeerManagementServerNodeResponse.java 0.00% 28 Missing ⚠️
...d/cluster/dao/ManagementServerHostPeerDaoImpl.java 0.00% 27 Missing ⚠️
...ain/java/com/cloud/api/query/QueryManagerImpl.java 0.00% 22 Missing ⚠️
...src/main/java/com/cloud/server/StatsCollector.java 0.00% 12 Missing ⚠️
...udstack/api/response/ManagementServerResponse.java 0.00% 11 Missing ⚠️
...uster/dao/ManagementServerHostPeerJoinDaoImpl.java 0.00% 11 Missing ⚠️
...m/cloud/server/ManagementServerHostStatsEntry.java 0.00% 6 Missing ⚠️
...ack/api/command/admin/management/ListMgmtsCmd.java 0.00% 3 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20    #9885      +/-   ##
============================================
+ Coverage     15.80%   15.98%   +0.17%     
- Complexity    12586    12772     +186     
============================================
  Files          5627     5631       +4     
  Lines        492294   499767    +7473     
  Branches      62198    63247    +1049     
============================================
+ Hits          77824    79869    +2045     
- Misses       405946   411052    +5106     
- Partials       8524     8846     +322

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov