[BEANUTILS-509] Wrap WeakHashMap in Collections.synchronizedMap #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@garydgregory any chance of a Beanutils2 release anytime soon? I think it just needs the whole codebase to be formatted and i think its worthy of a release. |
Member
|
There are a few more clean ups IIRC, I will try to take a look over the weekend. |
Contributor
Author
|
Thank you very much. |
Member
|
What are the performance consequences of this PR? |
Contributor
Author
|
No idea if there is a perfomance measurement suite I was just reading the ticket and it seems the Jenkins team definitely has this bug and use case. You are more than welcome to reject this PR. |
Contributor
Author
|
@garydgregory Just pinging you again about a potential BeanUtils2 release? |
Contributor
Author
|
Closing this PR in favor of #37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.