COMPRESS-723 : TAR PAX header parsing: enforce memory bound to mitigate resource exhaustion from oversized headers#770
Open
subbudvk wants to merge 7 commits intoapache:masterfrom
Open
Conversation
subbudvk
changed the title
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce a configurable memory bound on PAX header parsing via a new
maxPaxHeaderSizebuilder option onTarArchiveInputStreamandTarFile. The default is 10 MB (TarConstants.DEFAULT_MAX_PAX_HEADER_SIZE), enforced through the existingMemoryLimitException.checkBytes()mechanism. This closes the last unbounded allocation surface in the TAR parsing pipeline and follows the same defense-in-depth pattern already established for entry names and 7z headers.