Skip to content

JUnit5 assertThrows AbstractProxyFactoryTestCase #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nhojpatrick wants to merge 2 commits into
base: master
Choose a base branch
from
Open

JUnit5 assertThrows AbstractProxyFactoryTestCase #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20212a8
JUnit v5 api dependency to core
nhojpatrick Oct 19, 2022
c850b10
JUnit5 assertThrows AbstractProxyFactoryTestCase
nhojpatrick Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
<build>
<plugins>
Expand Down
25 changes: 13 additions & 12 deletions core/src/test/java/org/apache/commons/proxy2/AbstractProxyFactoryTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import static org.junit.Assert.assertNotSame;
import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
import static org.junit.jupiter.api.Assertions.assertThrows;

import java.io.IOException;
import java.io.Serializable;
Expand Down Expand Up @@ -221,18 +222,18 @@ public void testInterceptingProxySerializable() throws Exception
assertSerializable(proxy);
}

@Test(expected = IOException.class)
public void testInterceptorProxyWithCheckedException() throws Exception
@Test
public void testInterceptorProxyWithCheckedException()
{
final Echo proxy = factory.createInterceptorProxy(new EchoImpl(), new NoOpMethodInterceptor(), ECHO_ONLY);
proxy.ioException();
assertThrows(IOException.class, () -> proxy.ioException());
}

@Test(expected = IllegalArgumentException.class)
public void testInterceptorProxyWithUncheckedException() throws Exception
@Test
public void testInterceptorProxyWithUncheckedException()
{
final Echo proxy = factory.createInterceptorProxy(new EchoImpl(), new NoOpMethodInterceptor(), ECHO_ONLY);
proxy.illegalArgument();
assertThrows(IllegalArgumentException.class, () -> proxy.illegalArgument());
}

@Test
Expand Down Expand Up @@ -326,18 +327,18 @@ public void testPrimitiveParameter()
assertEquals(1, echo.echoBack(1));
}

@Test(expected = IOException.class)
public void testProxyWithCheckedException() throws Exception
@Test
public void testProxyWithCheckedException()
{
final Echo proxy = factory.createDelegatorProxy(new ConstantProvider<Echo>(new EchoImpl()), Echo.class);
proxy.ioException();
assertThrows(IOException.class, () -> proxy.ioException());
}

@Test(expected = IllegalArgumentException.class)
public void testProxyWithUncheckedException() throws Exception
@Test
public void testProxyWithUncheckedException()
{
final Echo proxy = factory.createDelegatorProxy(new ConstantProvider<Echo>(new EchoImpl()), Echo.class);
proxy.illegalArgument();
assertThrows(IllegalArgumentException.class, () -> proxy.illegalArgument());
}

@Test
Expand Down