Conversation
Codecov Report
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
- Coverage 66.41% 66.27% -0.15%
==========================================
Files 19 19
Lines 1849 1853 +4
==========================================
Hits 1228 1228
- Misses 621 625 +4
Continue to review full report at Codecov.
|
|
I went ahead and created a new Kotlin support PR so we can quickly apply all the changes and improvements to get Kotlin prepared and released hopefully in the next day or 2. Per your change request in the previous PR, I have:
NOTICE: If these are to be updated, it should be taken care of in a separate PR
|
|
@timbru31 I just added the Kotlin source set as well, per your change request's overview comment. The only thing I was not sure is if it was necessary to wrap that behind a flag too. |
IMO no need for a flag for adding the src/main/kotlin folder. Note that currently all plugin source files will end up in src/main/java because there's no special handling to detect kotlin files. |
c66388c to
7e5443d
Compare
| // Top-level build file where you can add configuration options common to all sub-projects/modules. | ||
|
|
||
| buildscript { | ||
| ext.kotlin_version = '1.3.50' |
There was a problem hiding this comment.
is this the Android Studio default?
There was a problem hiding this comment.
Yes, if you create a blank "No Activity" project in Android Studio, it has in the project's build.gradle:
ext.kotlin_version = '1.3.50'
7e5443d to
0f61780
Compare
knight9999
left a comment
There was a problem hiding this comment.
It looks fine.
I can run Kotlin code successfully with this PR.
18f9fe3 to
99ee5d0
Compare
Motivation and Context
To finish off the change requests and close out PR #441
closes: #441
Description
What this PR does:
EnableKotlintoGradlePluginKotlinEnabled(Default:false)GradlePluginKotlinCodeStyle(Default:official)GradlePluginKotlinVersion(Default:1.3.50)kotlin-android-extensionsplugin as well whenGradlePluginKotlinEnabledistruecompiletoimplementationTesting
npm tChecklist