Skip to content

chore: rename gradle plugin google services preference options#898

Merged
erisu merged 1 commit intoapache:masterfrom
erisu:feat/google-services
Jan 16, 2020
Merged

chore: rename gradle plugin google services preference options#898
erisu merged 1 commit intoapache:masterfrom
erisu:feat/google-services

Conversation

@erisu
Copy link
Copy Markdown
Member

@erisu erisu commented Jan 16, 2020

Motivation and Context

Change preference option names to increase better clarity by including more details.

Applied a pattern for all gradle related plugins:

GradlePlugin<Plugin-Name><Action/Property>

Description

  • GradlePluginGoogleServicesEnabled
  • GradlePluginGoogleServicesVersion

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 9.0.0 milestone Jan 16, 2020
Copy link
Copy Markdown
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu mentioned this pull request Jan 16, 2020
2 tasks
@erisu erisu merged commit 09256b7 into apache:master Jan 16, 2020
@erisu erisu deleted the feat/google-services branch January 16, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants