Skip to content
This repository was archived by the owner on May 25, 2021. It is now read-only.

Fix function_clause in childspec#3

Open
rnewson wants to merge 1 commit intoapache:masterfrom
cloudant:childspec-function-clause
Open

Fix function_clause in childspec#3
rnewson wants to merge 1 commit intoapache:masterfrom
cloudant:childspec-function-clause

Conversation

@rnewson
Copy link
Copy Markdown
Member

@rnewson rnewson commented Jul 13, 2015

Make couch_epi_functions:childspec's result match expectations of
couch_epi_functions:start_link function.

Make couch_epi_functions:childspec's result match expectations of
couch_epi_functions:start_link function.
@kxepal
Copy link
Copy Markdown
Member

kxepal commented Jul 13, 2015

+1

@kxepal
Copy link
Copy Markdown
Member

kxepal commented Jul 13, 2015

Btw, may be also update start_link signature?

start_link(ProviderApp, {epi_key, ServiceId}, {modules, Modules}, Options) 

to

start_link(ProviderApp, {epi_key, Key}, {modules, Modules}, Options) 

to avoid any confusions about what is ServiceId and what is Key.

@hubot hubot merged commit 3d0e6a6 into apache:master Jul 13, 2015
@rnewson
Copy link
Copy Markdown
Member Author

rnewson commented Jul 13, 2015

I'll talk with @iilyak. I don't know why, or much like, the use of tuples for single values ({epi_key, Key} and {modules, [Modules]}.

@davisp davisp deleted the childspec-function-clause branch October 22, 2015 06:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants