Skip to content
This repository was archived by the owner on Oct 17, 2022. It is now read-only.

feat: update docs for new query server config#328

Merged
wohali merged 1 commit intomasterfrom
fix/conf
Nov 21, 2018
Merged

feat: update docs for new query server config#328
wohali merged 1 commit intomasterfrom
fix/conf

Conversation

@janl
Copy link
Copy Markdown
Member

@janl janl commented Sep 14, 2018

@wohali
Copy link
Copy Markdown
Member

wohali commented Nov 9, 2018

Think this needs updating for changes to SSL config still. We fully scrubbed out proxy stuff and os_daemons already.

Don't think we need to document configuring the http global handlers, but if you want, go for it.

Comment thread src/config/query-servers.rst Outdated

Note, that you may set up multiple query servers for the same programming
language, but you have to name them different (like `python-dev` etc.).
language, but you have to name them different (like `PYTHONDEV` etc.).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you didn't change this, but "different" should be "differently", and "like" seems very informal, IMO.

Suggested change
language, but you have to name them different (like `PYTHONDEV` etc.).
language, but you have to name them differently (i.e. `PYTHON` and `PYTHONDEV`).

@wohali
Copy link
Copy Markdown
Member

wohali commented Nov 15, 2018

@janl please don't forget about this one, needs to land before 2.3.0 can go out the door. thanks!

@janl janl mentioned this pull request Nov 16, 2018
3 tasks
@wohali
Copy link
Copy Markdown
Member

wohali commented Nov 16, 2018

@janl since I merged the release notes already, and it includes everything for this PR, just drop your version of src/whatsnew/2.3.rst and src/whatsnew/index.rst and we should be fine.

@janl
Copy link
Copy Markdown
Member Author

janl commented Nov 21, 2018

@wohali can you take this over from me?

@wohali
Copy link
Copy Markdown
Member

wohali commented Nov 21, 2018

@janl ok

@wohali wohali force-pushed the fix/conf branch 4 times, most recently from 45f0daa to 902e049 Compare November 21, 2018 17:43
@wohali
Copy link
Copy Markdown
Member

wohali commented Nov 21, 2018

@flimzy can I get a final review here? I've rewritten a bunch of the...problematic text surrounding these changes to be more up to date (for instance, replacing "SSL config" with "HTTPS config", which I think more people will understand.)

Copy link
Copy Markdown
Member

@flimzy flimzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor change.

Comment thread src/config/query-servers.rst Outdated
Comment thread src/config/query-servers.rst
@wohali
Copy link
Copy Markdown
Member

wohali commented Nov 21, 2018

@flimzy Good catch, fixed! Will consider that a +1 and merge momentarily.

Thanks again for doing the bulk of the work here @janl !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants