This repository was archived by the owner on Oct 17, 2022. It is now read-only.
Update configuration of compaction daemon#386
Merged
wohali merged 3 commits intoapache:masterfrom Jan 31, 2019
Merged
Conversation
Since apache/couchdb@58fef34 "feat: bump the compaction daemon check_interval to one hour", the default value is `3600`.
Contributor
Author
|
I just updated the third commit to take the merge of apache/couchdb#1880 into account: --- a/src/config/compaction.rst
+++ b/src/config/compaction.rst
@@ -172,16 +172,19 @@ Configuration of Compaction Daemon
[compaction_daemon]
min_file_size = 131072
- .. config:option:: snooze_period
+ .. config:option:: snooze_period_ms
With lots of databases and/or with lots of design docs in one or more
databases, the compaction_daemon can create significant CPU load when
checking whether databases and view indexes need compacting. The
- snooze_period setting ensures a smoother CPU load. Defaults to
- 3 seconds wait.
+ ``snooze_period_ms`` setting ensures a smoother CPU load. Defaults to
+ 3000 milliseconds wait. Note that this option was formerly called
+ ``snooze_period``, measured in seconds (it is currently still
+ supported).
[compaction_daemon]
- snooze_period = 3
+ snooze_period_ms = 3000
+
.. _config/view_compaction:
|
Contributor
|
just double check, the default for |
Contributor
Author
|
No the default is 3000 milliseconds (i.e. 3 seconds). |
Contributor
|
then you may want to add snooze_period_ms around https://github.com/apache/couchdb-documentation/pull/386/files#diff-2942fe0bd584dca8819c4c3c22f3504bR184? |
5a90d09 to
6fae214
Compare
Contributor
Author
|
I pasted the diff but forgot to push... sorry about that and thanks for telling me! |
Contributor
|
Cool. There is one failure from travis. Could you please check? |
6fae214 to
381cb38
Compare
Contributor
Author
|
Sure, done! |
wohali
approved these changes
Jan 31, 2019
Member
wohali
left a comment
There was a problem hiding this comment.
Approved with minor changes, please revise
We had a hard time finding whether `check_interval` was waited between *each database compaction*, or between *a whole compaction run for all databases*. I propose to make it very explicit.
This new parameter was introduced in apache/couchdb@e5bf9d4 "add snooze_period doc to default.ini" and changed in apache/couchdb@5471694 "Add snooze_period_ms for finer tuning".
381cb38 to
3ab5ac4
Compare
Contributor
Author
|
Updated: --- a/src/config/compaction.rst
+++ b/src/config/compaction.rst
@@ -157,7 +157,7 @@ Configuration of Compaction Daemon
.. config:option:: check_interval
The delay, in seconds, between each check for which database and view
- indexes need to be compacted. In other words, this delay will be waited
+ indexes need to be compacted. In other words, this delay will occur
after *all* databases and views are compacted (or at least checked)::
[compaction_daemon]
@@ -178,9 +178,7 @@ Configuration of Compaction Daemon
databases, the compaction_daemon can create significant CPU load when
checking whether databases and view indexes need compacting. The
``snooze_period_ms`` setting ensures a smoother CPU load. Defaults to
- 3000 milliseconds wait. Note that this option was formerly called
- ``snooze_period``, measured in seconds (it is currently still
- supported).
+ 3000 milliseconds wait.
[compaction_daemon]
snooze_period_ms = 3000 |
Member
|
Thanks @adrienverge ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix default
check_intervalvalue in compaction docsSince apache/couchdb@58fef34 "feat: bump the compaction daemon
check_interval to one hour", the default value is
3600.Try to make
check_intervalexplanation clearerWe had a hard time finding whether
check_intervalwas waited betweeneach database compaction, or between a whole compaction run for all
databases.
I propose to make it very explicit.
Add missing
snooze_period_msin compaction docsThis new parameter was introduced in apache/couchdb@e5bf9d4 "add
snooze_period doc to default.ini" and changed in apache/couchdb@5471694
"Add snooze_period_ms for finer tuning".