Set query server env variable in Makefile for isolated eunit tests

[eiri]

Overview

After #1602 we requite env variable COUCHDB_QUERY_SERVER_JAVASCRIPT to point to js query server. This patch adds the env var on Makefile's eunit target returning ability to run the isolated eunit tests without setting that var in each tests' setup.

Testing recommendations

Isolated tests with query server, e.g. make eunit apps=couch_mrview suites=couch_mrview_all_docs_tests should run locally without throwing "unknown query server" exceptions.

Checklist

• Code is written and works correctly;
• Changes are covered by tests;
• Documentation reflects the changes;

[iilyak]

I think we can use ${BUILDDIR} instead of calling $(shell pwd) several times.

[eiri]

@iilyak I guess we can, but it's inconsistent with usage pwd everywhere else and feels kind of flimsy, setting env var in one step then depending on it in another.

Why do you want this change? It's not like here is a performance penalty we care about.

[iilyak]

but it's inconsistent with usage pwd everywhere else and feels kind of flimsy, setting env var in one step then depending on it in another.

I looked only at a diff and missed the fact that is used everywhere. It looked strange to see export BUILDIR and $(shell pwd) two lines bellow.

Why do you want this change?

It is just a suggestion I am fine with the way you wrote it.

[eiri]

It looked strange to see export BUILDIR and $(shell pwd) two lines bellow.

and one line above too 😄

Well, I agree it's not the best way to write Makefiles and better way to go about it would be something like ROOTDIR := $(shell pwd) to expand current dir at top of Makefile and then just use make's var ${ROOTDIR} everywhere else. But this is a bit bigger change for a quick fix I intended to do, so since you don't have strong feelings about it I'll go ahead with how it is.

[iilyak]

+1

[wohali]

@eiri see #1748, you should have done Makefile.win at the same time.

[eiri]

@wohali yes, my fault.