Skip to content

Use devclean on elixir target for consistency of Makefile#1785

Merged
eiri merged 3 commits intomasterfrom
devclean-on-elixir-target
Nov 30, 2018
Merged

Use devclean on elixir target for consistency of Makefile#1785
eiri merged 3 commits intomasterfrom
devclean-on-elixir-target

Conversation

@eiri
Copy link
Copy Markdown
Member

@eiri eiri commented Nov 30, 2018

Overview

This is a simple change of Makefile for consistency sake. Since dev/run overrides etc configs on each run functionally it's the same as earlier @rm command.

Testing recommendations

make elixir should pass, apart from common races.

Related Issues or Pull Requests

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

@wohali
Copy link
Copy Markdown
Member

wohali commented Nov 30, 2018

Please update Makefile.win at the same time!

@eiri
Copy link
Copy Markdown
Member Author

eiri commented Nov 30, 2018

@wohali Damn it! Sorry, I keep forgetting about Windows. Thank you for the remainder, will do in a moment.

@eiri
Copy link
Copy Markdown
Member Author

eiri commented Nov 30, 2018

@wohali Makefile.win updated. Sorry, I don't have a Win machine even as a VM, so can't actually test it. 😞

@dottorblaster
Copy link
Copy Markdown
Member

If we merge this, I'm going to update #1769 to include devclean for elixir-credo too. Kudos!

@wohali
Copy link
Copy Markdown
Member

wohali commented Nov 30, 2018

@dottorblaster Am wondering if we shouldn't split the credo/format/black syntax checks out into a new target that check calls, something like syntax-check that does all the syntax checks at once. We can then add syntax-check-update to actually format the code for developer happy fingers pre-PR.

@wohali
Copy link
Copy Markdown
Member

wohali commented Nov 30, 2018

@eiri +1 good to merge

@eiri eiri merged commit 510f267 into master Nov 30, 2018
@eiri eiri deleted the devclean-on-elixir-target branch November 30, 2018 21:31
@dottorblaster
Copy link
Copy Markdown
Member

@wohali I think we should address one issue at the time 🙂It's fine of course, but I think we need a roadmap, just like:

  • We merge Black checks
  • We merge Credo checks
  • We refactor those check in a syntax-check goal, addressing a subsequent issue

Is that ok for you? I think we are going to cross reference too much PRs otherwise 😄

@wohali
Copy link
Copy Markdown
Member

wohali commented Dec 1, 2018

@dottorblaster Yes, sorry, just wanted to get this idea out there, we could also take it to dev@couchdb.apache.org where it belongs :)

@dottorblaster
Copy link
Copy Markdown
Member

@wohali you did the right thing of course :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants