Update couchup#1868
Merged
wohali merged 1 commit intoapache:masterfrom Jan 21, 2019
Merged
Conversation
In python2 the urllib was not splitted yet like in python 3 so the correct is import quote directly from urlib if using python2
Member
|
@pealthoff Thanks, we'll take this, but keep in mind we don't support Python 2 for the script anymore, see line 1: https://github.com/apache/couchdb/blob/master/rel/overlay/bin/couchup#L1 |
janl
pushed a commit
that referenced
this pull request
Feb 7, 2019
Merged
janl
pushed a commit
that referenced
this pull request
Feb 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The couchup script was not running if using python2, missing the quote from urllib
According to the python3 docuymentation:
At the couchup script, the 2 alternatives at lines 22 and 24 are both importing the python3 alternative.
Testing recommendations
To test is just run the script on python2 before and after the change, because the error its just the import statement.