fix couchup for python3#1905
Merged
wohali merged 2 commits intoapache:masterfrom Feb 7, 2019
Merged
Conversation
wohali
approved these changes
Feb 5, 2019
Member
|
@klaemo Unfortunately I can't merge this because our style checker is failing. If you run Thanks again for your PR! |
A tale of strings, bytes and pyhon3, I guess
Contributor
Author
|
@wohali Done! ✅ Sorry I missed this step. |
janl
pushed a commit
that referenced
this pull request
Feb 7, 2019
Merged
janl
pushed a commit
that referenced
this pull request
Feb 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tale of strings, bytes and pyhon3, I guess. This is probably the first line of python I've written in my life. Hooray! 😀 I consulted this fun document to understand what's going on.
Overview
couchupcrashed in python3, becausebase64.b64encodeexpects a bytes-like object instead of a string. With this PR the string passed tobase64.b64encodeis properly encoded and decoded.Testing recommendations
Run couchup with credentials with python3:
couchup replicate -a --login admin --password <my-password>I was able to run couchup successfully on my DB with the change applied.
Related Issues or Pull Requests
fixes #1899
Checklist
Documentation reflects the changes;