Conversation
Remove all the plumbing that enabled `_external/` request handling, leaving only the functions necessary for `list` and `show`. closes #2166
cc73e09 to
3c55b95
Compare
kocolosk
approved these changes
Oct 9, 2019
Member
kocolosk
left a comment
There was a problem hiding this comment.
This is nicely conservative. One could imagine a more substantive refactor to remove the chttpd_external and couch_httpd_external modules entirely, but that should wait.
Member
Author
|
I think once |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Remove all the plumbing that enabled
_external/request handling,leaving only the functions necessary for
listandshow.closes #2166
Testing recommendations
N/A
Related Issues or Pull Requests
N/A
Checklist
rel/overlay/etc/default.ini