Skip to content

Remove "externals"#2248

Merged
rnewson merged 2 commits intomasterfrom
remove-externals
Oct 9, 2019
Merged

Remove "externals"#2248
rnewson merged 2 commits intomasterfrom
remove-externals

Conversation

@rnewson
Copy link
Copy Markdown
Member

@rnewson rnewson commented Oct 8, 2019

Overview

Remove all the plumbing that enabled _external/ request handling,
leaving only the functions necessary for list and show.

closes #2166

Testing recommendations

N/A

Related Issues or Pull Requests

N/A

Checklist

Remove all the plumbing that enabled `_external/` request handling,
leaving only the functions necessary for `list` and `show`.

closes #2166
Copy link
Copy Markdown
Member

@kocolosk kocolosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nicely conservative. One could imagine a more substantive refactor to remove the chttpd_external and couch_httpd_external modules entirely, but that should wait.

@rnewson
Copy link
Copy Markdown
Member Author

rnewson commented Oct 9, 2019

I think once _show and _list are removed, we can remove those modules but I didn't think now was the right time to move these (ancient) functions or attempt to consolidate them (there's a ton of overlap but perhaps subtle differences). Will merge if the Travis fairy grants my wish.

@rnewson rnewson merged commit 51cb66e into master Oct 9, 2019
@rnewson rnewson deleted the remove-externals branch October 9, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove /{db}/_external/* functionality

2 participants