Ignore extraneous cookie in replicator session plugin#5540
Merged
Conversation
Previously, the replictor session plugin emitted an error log line if it found only non-`AuthSession` cookies in the headers. It turns out, as we saw in #1851, some proxies can set their own cookies, and so CouchDb replicator should expect and skip over those without generating excessive log noise. Fix #1851
janl
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the replictor session plugin emitted an error log line if it found only non-
AuthSessioncookies in the headers.It turns out, as we saw in #1851, some proxies can set their own cookies, and so CouchDb replicator should expect and skip over those without generating excessive log noise.
Fix #1851