Skip to content

RAT-551: Replace NoCloseOutputStream with Apache Commons CloseShieldOutputStream#653

Open
Claudenw wants to merge 2 commits intomasterfrom
remove-nocloseoutputstream
Open

RAT-551: Replace NoCloseOutputStream with Apache Commons CloseShieldOutputStream#653
Claudenw wants to merge 2 commits intomasterfrom
remove-nocloseoutputstream

Conversation

@Claudenw
Copy link
Copy Markdown
Contributor

Removes custom NoCloseOutputStream with the Apache commons CloseShieldOutputStream

@Claudenw Claudenw requested a review from ottlinger April 27, 2026 10:58
@ottlinger
Copy link
Copy Markdown
Contributor

@Claudenw is it merely to use existing library code or is there a different motivation behinde the change?

Sonar fails due to not knowing the context of the code, but can be ignored.

Copy link
Copy Markdown
Contributor

@ottlinger ottlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - do we have a code that explicitly triggers this or is it done implicitly by integration/example docs?

@Claudenw
Copy link
Copy Markdown
Contributor Author

NoCloseOutputStream was custom rolled and caused problems with some checkers as they could not determine if the OutputStream was closed. The Apache version works well with checkers and is included in a library we already use.

So simplifies our code.
Makes code cleaner for checkers.

@ottlinger ottlinger changed the title Replace NoCloseOutputStream with apache commons CloseShieldOutputStream Replace NoCloseOutputStream with Apache Commons CloseShieldOutputStream Apr 28, 2026
@ottlinger ottlinger changed the title Replace NoCloseOutputStream with Apache Commons CloseShieldOutputStream RAT-551: Replace NoCloseOutputStream with Apache Commons CloseShieldOutputStream Apr 28, 2026
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants