CURATOR-523: Fix ByteBuffer's compatibility issues#321
Merged
shayshim merged 1 commit intoapache:masterfrom Aug 22, 2019
asdf2014:fix_bytebuffer
Merged
CURATOR-523: Fix ByteBuffer's compatibility issues#321shayshim merged 1 commit intoapache:masterfrom asdf2014:fix_bytebuffer
shayshim merged 1 commit intoapache:masterfrom
asdf2014:fix_bytebuffer
Conversation
Member
Author
|
Thanks, LGTM |
Member
|
LGTM, although I don't see how the diff relates to the title of the PR. |
Member
Author
|
@pacomendes @leventov Thank you for your comments. This title is mainly used to indicate that the underlying purpose of this PR is to resolve ByteBuffer compatibility issues caused by the JDK version. 😅 |
Member
Author
|
@shayshim Can we move this forward? Apache Druid wants to upgrade to the new version of Curator, but it was blocked by this issue. More details: apache/druid#8177 |
|
@Randgalt can we merge this in? |
Member
|
I'll try to get to it soon. Or maybe @shayshim or @cammckenzie can do it. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.