(test) Add test for InstanceSpec.<init> and .getQuorumPort

[lacinoire]

Hey 😊
I want to contribute the following test:

Test that spec.getQuorumPort() is equal to 2.
This tests the methods InstanceSpec.<init> and InstanceSpec.getQuorumPort.
This test is based on the test setCustomTickTimeTest.

Curious to hear what you think!

(I wrote this test as part of a research study at TU Delft. Find out more)

[tisonkun]

This patch seems like an explicit test of getter/setter. Basically it's meaningless and we don't test such methods.

Could you elaborate why you'd like to add such a test?

[lacinoire]

Good point regarding the getter method.
I still proposed the test case because it also covers new instructions in the constructor of InstanceSpec (setting the quorum port to the passed value if it is larger than 0).

Do you find it meaningful to test (this kind of) constructor?

[tisonkun]

Closed as we don't test for simple getter/setter.

If you're interested in setting port correctly, you may take a look at CURATOR-535, related patches:

• [CURATOR-535] TestServer random port selection has a race condition #406
• CURATOR-535: Fix client port conflict due to untrustworthy random port allocation #421