fix: generate integer keys instead of floats in TPC-DS data#31
Open
Dandandan wants to merge 1 commit intoapache:mainfrom
Open
fix: generate integer keys instead of floats in TPC-DS data#31Dandandan wants to merge 1 commit intoapache:mainfrom
Dandandan wants to merge 1 commit intoapache:mainfrom
Conversation
Author
|
@comphead FYI |
The pre-existing SF1 parquet data had nullable integer columns (surrogate keys, quantities, etc.) incorrectly stored as double (float64). This was likely caused by an older version of datafusion-python or dsdgen. Regenerated all SF1 parquet data with dsdgen v4.0.0 and the current datafusion-python, which correctly writes int32 columns. Also fixed trailing pipe detection in tpcdsgen.py to work with dsdgen v4.0.0 (which no longer adds a trailing | as field terminator), and switched to zstd compression. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Dandandan
force-pushed
the
fix-tpcds-integer-keys
branch
from
97563d3 to
f1560cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tpcdsgen.pytrailing pipe detection to work with dsdgen v4.0.0 (which no longer adds a trailing|as field terminator)double/float64instead ofint32Background
The pre-existing SF1 parquet data had ~100 columns across 15 tables stored as
doublethat should beint32(e.g.ss_sold_date_sk,cs_bill_customer_sk,ss_quantity). This was likely caused by an older version of datafusion-python or dsdgen. The current datafusion-python correctly writes int32 columns when an explicit schema is provided.Test plan
mainhavedoubletypes for key columnsdoublecolumns🤖 Generated with Claude Code